Review main Merged

89019[TASK] Raise codeception to unlock phpunit:^12

Wouter Wolters CR +2 V +2 Normal +105 −94 updated 04/10/25, 19:19

Commit message

> composer u typo3/testing-framework
> composer req --dev -w codeception/codeception:^5.2.1 \
	codeception/module-webdriver:^4.0.3 \
	codeception/lib-asserts:^2.2.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2130

Show 35 earlier messages
  1. Wouter Wolters uploaded patch set 1 04/09/25, 21:12

  2. core-ci voted on patch set 1 V +1 04/09/25, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77324

  3. Wouter Wolters updated the commit message in patch set 2 V +1 04/09/25, 21:25

  4. core-ci voted on patch set 2 V +1 04/09/25, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77327

  5. Oliver Klee voted on patch set 2 CR +1 V +1 04/10/25, 07:50

  1. Andreas Kienast uploaded patch set 3 CR +1 V +1 04/10/25, 08:00

  2. core-ci voted on patch set 3 V +1 04/10/25, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77399

  3. Oliver Klee voted on patch set 3 CR +1 V +1 04/10/25, 08:08

  4. Stefan Bürk commented on patch set 3 V -1 04/10/25, 08:08

    -1 on this (temp) Going to start a nightly. And before merging we need to tag TF first for the 13.4 backport.
  5. Stefan Bürk commented on patch set 3 04/10/25, 08:09

    Reply

    Thanks for providing this @typo3@wouterwolters.nl
  6. Stefan Bürk voted on patch set 3 V 0 CR -1 04/10/25, 08:09

  7. core-ci voted on patch set 3 V -1 04/10/25, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77401

  8. Oliver Klee voted on patch set 3 CR 0 V 0 04/10/25, 08:45

  9. Stefan Bürk uploaded patch set 4 CR -1 V -1 04/10/25, 13:33

  10. Stefan Bürk commented on patch set 4 04/10/25, 13:34

    Codeception ^5.2.1 required, 5.2.0 included a regressesion for us thankfully fixed by @gh@faktor-e.de: https://github.com/Codeception/Codeception/pull/6828
  11. Stefan Bürk voted on patch set 4 CR -1 04/10/25, 13:35

  12. core-ci voted on patch set 4 V +1 04/10/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77439

  13. Oliver Klee voted on patch set 4 CR +1 04/10/25, 13:50

  14. core-ci voted on patch set 4 V -1 04/10/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77440

  15. Oliver Klee voted on patch set 4 CR 0 04/10/25, 14:14

  16. core-ci commented on patch set 4 04/10/25, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77440

  17. Stefan Bürk commented on patch set 4 04/10/25, 14:20

    Failing nightly unrelated to this change, but needs to be addressed first. Stay tuned.
  18. Stefan Bürk rebased onto patch set 5 CR -1 V -1 04/10/25, 18:16

  19. Stefan Bürk voted on patch set 5 CR -1 04/10/25, 18:16

  20. core-ci voted on patch set 5 V +1 04/10/25, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77457

  21. core-ci commented on patch set 5 04/10/25, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77458

  22. Oliver Klee voted on patch set 5 CR +1 V +1 04/10/25, 18:53

  23. Stefan Bürk voted on patch set 5 CR +2 V +2 04/10/25, 19:19

  24. Stefan Bürk commented on patch set 5 04/10/25, 19:19

    Reply

    Done
  25. Stefan Bürk merged patch set 6 04/10/25, 19:19