Review main Merged

89024[BUGFIX] Use integer return value in sorting callback

Georg Ringer CR +2 V +2 Easy +1 −1 updated 04/10/25, 08:38

Commit message

Replace deprecated bool value false in return value of the sorting
callback.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 04/09/25, 21:34

  2. Georg Ringer commented on patch set 1 04/09/25, 21:34

    This change is ready for review.
  3. Benni Mack updated the commit message in patch set 2 04/09/25, 21:36

  4. core-ci voted on patch set 1 V +1 04/09/25, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77331

  5. core-ci voted on patch set 2 V +1 04/09/25, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77332

  6. Benni Mack voted on patch set 2 CR +1 V +1 04/09/25, 22:31

  7. Oliver Klee voted on patch set 2 CR +1 04/10/25, 07:50

  8. Markus Klein voted on patch set 2 CR +1 V +1 04/10/25, 07:52

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/10/25, 07:54

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 04/10/25, 07:58

  11. Benni Mack voted on patch set 2 CR +2 V +2 04/10/25, 08:38

  12. Benni Mack merged patch set 3 04/10/25, 08:38