89032[BUGFIX] Preserve transparency for image/graphicsmagick conversions
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+2 −1
- typo3/sysext/core/Classes/Utility/CommandUtility.php+5 −0
- typo3/sysext/install/Classes/Controller/EnvironmentController.php3+64 −0
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+6 −0
- typo3/sysext/install/Resources/Public/Images/TestInput/Transparent.svgnew+4 −0
- typo3/sysext/install/Resources/Public/Images/TestReference/Convert-svg-transparent.pngnewbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Convert-svg-transparent.webpnewbinary
Review log 1723
-
Garvin Hicking uploaded patch set 1 04/10/25, 09:08
-
core-ci voted on patch set 1 V +1 04/10/25, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77417
-
Garvin Hicking marked it work in progress 04/10/25, 09:32
-
Garvin Hicking uploaded patch set 2
V +104/10/25, 10:24 -
Garvin Hicking commented on patch set 2 04/10/25, 10:24
This change is ready for review. -
core-ci voted on patch set 2 V -1 04/10/25, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77427
-
Garvin Hicking uploaded patch set 3
V -104/10/25, 10:33 -
Garvin Hicking commented on patch set 4 04/10/25, 10:38
Published edit on patch set 3. -
core-ci voted on patch set 3 V +1 04/10/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77430
-
core-ci voted on patch set 4 V +1 04/10/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77431
-
Benni Mack updated the commit message in patch set 5
V +104/15/25, 15:33 -
Benni Mack voted on patch set 5 CR +1 04/15/25, 15:33
-
core-ci voted on patch set 5 V +1 04/15/25, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77768
-
Benni Mack voted on patch set 5 V +1 04/16/25, 06:21
-
Andreas Kienast commented on patch set 5 V -1 04/16/25, 07:03
EnvironmentController.php:682why do we pass a height here? This causes distorted renderings in my tests. -
Garvin Hicking uploaded patch set 6
CR +1V +104/16/25, 07:29 -
Garvin Hicking commented on patch set 6 04/16/25, 07:30
EnvironmentController.php:682ReplyThanks a lot. That was not intentional and a leftover from my tests. (However I don't understand why it showed up for me scaled normally, and not for you - but omitting height like in the other tests still also works for me) -
core-ci voted on patch set 6 V +1 04/16/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77808
-
Garvin Hicking commented on patch set 6 04/16/25, 07:36
EnvironmentController.php:682ReplyOK, Andi pointed me at it: I had `GFX.processor_allowUpscaling` set to `false`, this is why my system behaved differently. Case closed. -
Andreas Kienast voted on patch set 6 CR +1 V +1 04/16/25, 07:39
-
Benni Mack voted on patch set 6 CR +1 V +1 04/16/25, 08:41
-
Garvin Hicking voted on patch set 6 CR +2 V +2 04/16/25, 08:41
-
Garvin Hicking merged patch set 7 04/16/25, 08:41