Review main Merged

89038[BUGFIX] Fix end of tag names in parseFunc

Marcel Jürgen Falk CR +2 V +2 Normal +84 −1 updated 04/12/25, 17:52

Commit message

The HTML specification allows tag names to end in spaces, line feeds,
character tabulation and form feeds. The current parseFunc only splits
at spaces. If an allowlist of tags is used, this can trigger an allowed
tag to be denied (or a denied tag to be allowed).

This commit implements all the characters that can split attributes from
tag names.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Marcel Jürgen Falk uploaded patch set 1 04/10/25, 13:26

  2. core-ci voted on patch set 1 V +1 04/10/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77438

  3. Markus Klein commented on patch set 1 04/10/25, 15:15

    We should add a test for this. Let's check if there is already something we can build upon
  4. Garvin Hicking updated the commit message in patch set 2 V +1 04/10/25, 17:34

  5. Garvin Hicking commented on patch set 2 04/10/25, 17:36

    Reply

    Thanks for this, and I agree, we should work out a test for it! (BTW: What about \r?)
  6. core-ci voted on patch set 2 V +1 04/10/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77454

  7. Benni Mack uploaded patch set 3 V +1 04/12/25, 16:21

  8. Benni Mack commented on patch set 3 04/12/25, 16:21

    Reply

    I added tests and did not find any. Interesting that this issue did not pop up earlier... looks like it's not such a HUGE deal.
  9. core-ci voted on patch set 3 V +1 04/12/25, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77630

  10. Garvin Hicking uploaded patch set 4 V +1 04/12/25, 17:30

  11. Garvin Hicking commented on patch set 4 CR +1 V +1 04/12/25, 17:31

    Reply

    Nice, thanks. I just added two more variants actually including tab and form feed into the mix.
  12. core-ci voted on patch set 4 V +1 04/12/25, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77636

  13. Benni Mack voted on patch set 4 CR +2 V +2 04/12/25, 17:52

  14. Benni Mack merged patch set 5 04/12/25, 17:52