89045[TASK] Improve view of redirects to disabled pages
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageRecordViewHelper.phprenamed+10 −6
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+7 −2
- typo3/sysext/redirects/Tests/Functional/ViewHelpers/Fixtures/targetPageIdViewHelper_pages.csvnew+6 −0
- typo3/sysext/redirects/Tests/Functional/ViewHelpers/TargetPageIdViewHelperTest.phpdeleted+0 −53
- typo3/sysext/redirects/Tests/Functional/ViewHelpers/TargetPageRecordViewHelperTest.phpnew+103 −0
Review log 1013
-
Georg Ringer uploaded patch set 1 04/10/25, 19:42
-
Georg Ringer commented on patch set 1 04/10/25, 19:42
This change is ready for review. -
core-ci voted on patch set 1 V -1 04/10/25, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77466
-
Stefan Bürk commented on patch set 1 CR -1 04/11/25, 08:21
On it ... -
Stefan Bürk uploaded patch set 2
CR -1V -104/11/25, 08:47 -
Stefan Bürk commented on patch set 2 04/11/25, 08:51
Reply
Pushed ... * reworked functional tests (fix issue and add more tests) * adding a fallback for the `BU::getRecord()` call to return an empty instead of null to mitigate a TypeError In general, we should consider/discuss two things: * The ViewHelper name does not reflect anymore what it returns and should be renamed to `TargetPageRecordViewHelper` or `TargetPageRowViewHelper`. * Empty array return in case of nothing returned is kind of weired. Should we make the return type nullable and only return an array when a record could be determined in in the other cases `null` ? What do you think ? -
core-ci voted on patch set 2 V +1 04/11/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77503
-
Stefan Bürk uploaded patch set 3
V +104/11/25, 11:53 -
Stefan Bürk commented on patch set 3 04/11/25, 11:53
Reply
Kept (empty) array return value but renamed the ViewHelper and the test for it. -
core-ci voted on patch set 3 V +1 04/11/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77523
-
Benni Mack voted on patch set 3 CR +1 V +1 04/11/25, 12:26
-
Stefan Bürk voted on patch set 3 CR +2 V +2 04/11/25, 12:34
-
Stefan Bürk merged patch set 4 04/11/25, 13:25