Review main Merged

89045[TASK] Improve view of redirects to disabled pages

Georg Ringer CR +2 V +2 Normal +126 −61 updated 04/11/25, 13:25

Commit message

If a redirect redirects to a page, the icon of the page is now
shown before the page id. This helps to identify problems which
occur if the page is disabled and the redirect would not work.

The internal `EXT:redirects` ViewHelper is modified to return
the page record instead of the pageId and renamed to reflect
the changed return value. Template is adopted to the new name.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1013

  1. Georg Ringer uploaded patch set 1 04/10/25, 19:42

  2. Georg Ringer commented on patch set 1 04/10/25, 19:42

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 04/10/25, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77466

  4. Stefan Bürk commented on patch set 1 CR -1 04/11/25, 08:21

    On it ...
  5. Stefan Bürk uploaded patch set 2 CR -1 V -1 04/11/25, 08:47

  6. Stefan Bürk commented on patch set 2 04/11/25, 08:51

    Reply

    Pushed ... * reworked functional tests (fix issue and add more tests) * adding a fallback for the `BU::getRecord()` call to return an empty instead of null to mitigate a TypeError In general, we should consider/discuss two things: * The ViewHelper name does not reflect anymore what it returns and should be renamed to `TargetPageRecordViewHelper` or `TargetPageRowViewHelper`. * Empty array return in case of nothing returned is kind of weired. Should we make the return type nullable and only return an array when a record could be determined in in the other cases `null` ? What do you think ?
  7. core-ci voted on patch set 2 V +1 04/11/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77503

  8. Stefan Bürk uploaded patch set 3 V +1 04/11/25, 11:53

  9. Stefan Bürk commented on patch set 3 04/11/25, 11:53

    Reply

    Kept (empty) array return value but renamed the ViewHelper and the test for it.
  10. core-ci voted on patch set 3 V +1 04/11/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77523

  11. Benni Mack voted on patch set 3 CR +1 V +1 04/11/25, 12:26

  12. Stefan Bürk voted on patch set 3 CR +2 V +2 04/11/25, 12:34

  13. Stefan Bürk merged patch set 4 04/11/25, 13:25