Review main Merged

89046[TASK] Add tests for localizing records with flexform

Benni Mack CR +2 V +2 Expert +1270 −40 updated 04/11/25, 08:52

Commit message

This adds (wrong) tests when localizing records
in FlexForm, which should be fixed with #101962

The current situation:

1) when in live (Modify), localize within FlexForm relations
   does not work, and we just have language=0 on all inline
   relations.

2) When discarding, the attached relations dont get discarded

3) When in a WS, translated relations are in default language as well

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 29

Show 9 more files

Review log 1218

  1. Benni Mack uploaded patch set 1 04/10/25, 19:53

  2. core-ci voted on patch set 1 V -1 04/10/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77467

  3. Stefan Bürk uploaded patch set 2 V -1 04/10/25, 20:05

  4. core-ci voted on patch set 2 V +1 04/10/25, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77469

  5. Stefan Bürk commented on patch set 2 04/10/25, 20:28

    Issue missing - otherwise this looks good.
  6. Benni Mack updated the commit message in patch set 3 V +1 04/10/25, 20:44

  7. Benni Mack commented on patch set 3 04/10/25, 20:46

    Reply

    Done
  8. Benni Mack uploaded patch set 4 04/10/25, 20:48

  9. core-ci voted on patch set 3 V +1 04/10/25, 20:52 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 4 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77472

  10. core-ci voted on patch set 4 V +1 04/10/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77473

  11. Benni Mack uploaded patch set 5 V +1 04/10/25, 21:13

  12. core-ci voted on patch set 5 V +1 04/10/25, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77475

  13. Benni Mack uploaded patch set 6 V +1 04/10/25, 22:02

  14. core-ci voted on patch set 6 V +1 04/10/25, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77477

  15. Garvin Hicking voted on patch set 6 CR +1 V +1 04/11/25, 07:40

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 04/11/25, 08:01

  17. Stefan Bürk voted on patch set 6 CR +2 V +2 04/11/25, 08:18

  18. Stefan Bürk merged patch set 7 04/11/25, 08:52