Review 13.4 Merged

89047[BUGFIX] Fix Frontend translations for file metadata in free mode

Stefan Bürk CR +2 V +2 Hard +255 −11 updated 04/10/25, 20:46

Commit message

When rendering a frontend in a language set to free
mode (= just do a SQL query for e.g. language=5), sys_file_metadata
is now also shown in the frontend's language.

The logic within FileMetadataAspect is always loading the
default language (L=0) and for this, we need to call
PageRepository->getLanguageOverlay() for "sys_file_metadata"
and even when running in free mode, handle a "translation"
for sys_file_metadata just like we'd do overlays.

This is the same concept that TYPO3 needs to use for pages
(page always resolves to a default language record).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Stefan Bürk uploaded patch set 1 04/10/25, 20:14

  2. Stefan Bürk uploaded patch set 2 04/10/25, 20:16

  3. core-ci voted on patch set 2 V +1 04/10/25, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77471

  4. core-ci voted on patch set 1 V -1 04/10/25, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77470

  5. Benni Mack voted on patch set 2 CR +2 V +2 04/10/25, 20:46

  6. Benni Mack merged patch set 3 04/10/25, 20:46