Review main Merged

89051[BUGFIX] Properly calculate the effective PID for page translations or versioned pages

Benni Mack CR +2 V +2 Easy +44 −1 updated 04/11/25, 21:41

Commit message

When using the marker ##CURRENT_PID### inside FormEngine, TSconfig
etc. FormEngine calculates the so-called "effectivePid"
which points to the parents' page UID, the PID. When
editing the actual page on the root-level, it's the same.

This is relevant when editing page translations, or when
editing a page in a workspace, because there was a bug:

While migrating from pages_language_overlay we forgot to
actually adapt the effectivePid to the proper record.

- For pages in default language (live), it's the "uid"
- For page translations (live), it's the "l10n_parent"
- For pages in default language (workspace), it's the "t3ver_oid"
- For page translations (workspace), it's the "l10n_parent"
  which also points to the LIVE record of the default language.

Workspace hint: This was not easy to deal with until v10, while we
still had pid=-1 records for versioned records.

Language hint (although not directly related here): the PID
and the sorting parameter of a page translation is also the same as
the PID of the page in the default language.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Philipp Kitzberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Philipp Kitzberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 04/11/25, 08:36

  2. core-ci voted on patch set 1 V -1 04/11/25, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77501

  3. Benni Mack uploaded patch set 2 V -1 04/11/25, 08:55

  4. core-ci voted on patch set 2 V +1 04/11/25, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77506

  5. Philipp Kitzberger voted on patch set 2 CR +1 V +1 04/11/25, 21:07

  6. Stefan Bürk voted on patch set 2 CR +2 V +2 04/11/25, 21:27

  7. Stefan Bürk merged patch set 3 04/11/25, 21:41