Review main Merged

89052[BUGFIX] Avoid using native filemtime for calculation of paths

Benni Mack CR +2 V +2 Easy +5 −2 updated 04/11/25, 20:37

Commit message

When generating the preview images in the FileList,
a change was added to use filemtime for "absolute path",
whereas paths such as "/_assets/..." are technically
absolute, but are already absolute web paths generated
by "getPublicUrl()" of FAL.

For this reason, cache busting is added manually via
the FAL API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 04/11/25, 09:44

  2. core-ci voted on patch set 1 V +1 04/11/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77511

  3. Andreas Kienast voted on patch set 1 CR +1 04/11/25, 10:11

  4. Georg Ringer voted on patch set 1 CR +1 V +1 04/11/25, 20:10

  5. Benni Mack voted on patch set 1 CR +2 V +2 04/11/25, 20:37

  6. Benni Mack merged patch set 2 04/11/25, 20:37