Review 12.4 Merged

89054[BUGFIX] Fix preview with extendToSubpages

Stefan Bürk CR +2 V +2 Easy +17 −18 updated 04/11/25, 12:00

Commit message

A problem in combination with extendToSubpages still existed and
resulted in page displayed with a 403 error, if logged in the
backend, if

- current page is hidden=0
- current page has extendToSubpages=1
- parent page has hidden=1
- parent page has extendToSubpages=1
- user is logged in Backend and opens pages via preview
- admin panel is not active

The problem did not exist if the current page had extendToSubpages=0,
which was introduced while fixing issue #17599.

This is now fixed: In PreviewSimulator::checkIfRootlineRequiresPreview
it was checked if the current page has extendToSubpages=1, but this
is completely irrelevant to the visibility of the current page.
So the check is removed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 4

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/11/25, 11:37

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 04/11/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77522

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/11/25, 11:59

  4. Stefan Bürk merged patch set 2 04/11/25, 12:00