Review main Merged

89056[BUGFIX] Fix possible PHP type error in DateTimeFactory

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 04/11/25, 13:05

Commit message

Explicitly cast `nullable` setting coming from TCA config to `bool`
before passing it to `DateTimeFactory::fromDatabase`, as this method
expects a `bool` to be supplied, and there are cases where extension
authors use `nullable=0` instead of `nullable=false`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Benjamin Franzke uploaded patch set 1 04/11/25, 12:06

  2. core-ci voted on patch set 1 V +1 04/11/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77525

  3. Benni Mack voted on patch set 1 CR +1 V +1 04/11/25, 12:26

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 04/11/25, 12:51

  5. Andreas Kienast merged patch set 2 04/11/25, 13:05