Review main Merged

89064[BUGFIX] Prevent file selection via name link when denied by IsFileSelectableEvent

HOJA M A CR +2 V +2 Easy +6 −2 updated 04/11/25, 16:33

Commit message

When a file is marked as non-selectable using IsFileSelectableEvent, the
file browser correctly removes the '+' icon and checkboxes. However, the
file could still be selected by clicking on the file name.

This patch ensures that when a file is not selectable, the attribute
`data-filelist-action` is not set, and the button is instead disabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. HOJA M A uploaded patch set 1 04/11/25, 14:44

  2. core-ci voted on patch set 1 V -1 04/11/25, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77543

  3. Benni Mack uploaded patch set 2 V -1 04/11/25, 15:35

  4. Benni Mack updated the commit message in patch set 3 04/11/25, 15:36

  5. Benni Mack voted on patch set 3 CR +1 V +1 04/11/25, 15:36

  6. core-ci voted on patch set 2 V +1 04/11/25, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77551

  7. core-ci voted on patch set 3 V +1 04/11/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77552

  8. Andreas Kienast commented on patch set 3 CR -1 04/11/25, 16:06

    on it
  9. Andreas Kienast uploaded patch set 4 CR +1 V +1 04/11/25, 16:08

  10. Andreas Kienast commented on patch set 4 CR +1 V +1 04/11/25, 16:08

    Reply

    Done
  11. core-ci voted on patch set 4 V +1 04/11/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77559

  12. Benni Mack voted on patch set 4 CR +2 V +2 04/11/25, 16:33

  13. Benni Mack merged patch set 5 04/11/25, 16:33