Review main Merged

89074[BUGFIX] Generate proper file path for ImageResource objects

Benni Mack CR +2 V +2 Easy +12 −13 updated 04/12/25, 18:56

Commit message

While refactoring "imgInfo" in #102755 (which was the
ugly array list of 0,1,2,3) into a DTO called
"ImageResource", an error was made to send a manually
calculated full path from
Environment::getPublicPath() . '/' . $processedFile->getPublicUrl()
into the DTO.

This is obviously wrong, as getPublicUrl() can be referenced
by e.g. the full URL via Events etc.

FAL offers the full path by providing $file->getForLocalProcessing()
to have a real local path.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 04/11/25, 21:06

  2. Benni Mack updated the commit message in patch set 2 04/11/25, 21:06

  3. Benni Mack updated the commit message in patch set 3 04/11/25, 21:07

  4. core-ci voted on patch set 1 V +1 04/11/25, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77579

  5. core-ci voted on patch set 3 V +1 04/11/25, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77581

  6. core-ci voted on patch set 2 V +1 04/11/25, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77580

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 04/12/25, 13:31

  8. Georg Ringer voted on patch set 3 CR +1 V +1 04/12/25, 18:23

  9. Stefan Bürk voted on patch set 3 CR +2 V +2 04/12/25, 18:46

  10. Stefan Bürk merged patch set 4 04/12/25, 18:56