Review main Merged

89086[TASK] Add tests for localization l10n_mode=exclude

Benni Mack CR +2 V +2 Hard +254 −0 updated 04/12/25, 20:22

Commit message

This is a leftover from adding tasks 5 years ago,
where this use-case was missing and not added yet.

There is an interesting side-effect in workspaces:
Because the localization happens in the WS, the default
language needs to be created as well. l10n_mode exclude
means that it modifies all languages - thus creating
a regular "t3ver_state=0" record as well (= 2 versioned records).

When "Publish Workspace" (publishAll) is used, the
modified default language version is overwriting the live
record. This is a nasty issue, because if the live record in
default language might be modified during that time, it
might be overwriting live changes by accident.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 68

  1. Benni Mack uploaded patch set 1 04/12/25, 17:40

  2. core-ci voted on patch set 1 V +1 04/12/25, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77637

  3. Stefan Bürk updated the commit message in patch set 2 V +1 04/12/25, 19:06

  4. core-ci voted on patch set 2 V +1 04/12/25, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77641

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/12/25, 19:23

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 04/12/25, 20:21

  7. Benni Mack voted on patch set 2 CR +2 V +2 04/12/25, 20:22

  8. Benni Mack merged patch set 3 04/12/25, 20:22