Review main Merged

89097[BUGFIX] Avoid reaching placeholder limit when clearing processed files

Till Hörner CR +2 V +2 Easy +14 −8 updated 04/14/25, 20:29

Commit message

The cleanup:localprocessedfiles command deletes processed files and
their database records. Given a large enough table of processed files
this could reach the placeholder limit. To avoid this split the record
uids into smaller chunks.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Till Hörner uploaded patch set 1 04/14/25, 07:56

  2. core-ci voted on patch set 1 V +1 04/14/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77690

  3. Andreas Kienast voted on patch set 1 CR +1 04/14/25, 09:43

  4. Andreas Kienast commented on patch set 1 CR 0 04/14/25, 12:51

    CleanUpLocalProcessedFilesService.php:225

    Why do we have to preserve the keys here?
  5. Till Hörner uploaded patch set 2 V +1 04/14/25, 14:08

  6. Till Hörner commented on patch set 2 04/14/25, 14:14

    CleanUpLocalProcessedFilesService.php:225 Reply

    I don't think we have to. Just copied this from other places in core. Removed it now
  7. core-ci voted on patch set 2 V +1 04/14/25, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77703

  8. Andreas Kienast voted on patch set 2 CR +1 04/14/25, 14:34

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 04/14/25, 16:18

  10. Georg Ringer voted on patch set 2 CR +2 V +2 04/14/25, 20:29

  11. Georg Ringer merged patch set 3 04/14/25, 20:29