Review main Merged

89113[TASK] Provide icon cache identifier when rendering backend

Andreas Kienast CR +2 V +2 Normal +51 −78 updated 04/16/25, 08:14

Commit message

The icon cache identifier used by TYPO3 to decide whether icons stored
in browser's localStorage is now provided directly within the global
`TYPO3` object when the backend and its modules get rendered.

This eliminates the need for a dedicated endpoint that provides this
information, saving one AJAX call per invocation of the
`@typo3/backend/icons` module.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1926

Show 1 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/15/25, 07:47

  1. core-ci voted on patch set 1 V -1 04/15/25, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77737

  2. Andreas Kienast marked it work in progress 04/15/25, 08:02

  3. Andreas Kienast uploaded patch set 2 V -1 04/15/25, 08:50

  4. core-ci voted on patch set 2 V -1 04/15/25, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77739

  5. Andreas Kienast uploaded patch set 3 V -1 04/15/25, 08:56

  6. Andreas Kienast commented on patch set 3 04/15/25, 08:59

    This change is ready for review.
    I'm still undecided what's the best code path to put the global assignment for the cache identifier. Putting it in BackendController and ModuleTemplate works but has two potential issues: * code is duplicated * this will break for backend modules that don't use ModuleTemplate
  7. core-ci voted on patch set 3 V +1 04/15/25, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77740

  8. Andreas Kienast uploaded patch set 4 V +1 04/15/25, 09:47

  9. Andreas Kienast commented on patch set 4 04/15/25, 09:47

    Reply

    Done
  10. core-ci voted on patch set 4 V -1 04/15/25, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77746

  11. Andreas Kienast uploaded patch set 5 V -1 04/15/25, 09:55

  12. core-ci voted on patch set 5 V +1 04/15/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77747

  13. Benjamin Franzke commented on patch set 5 CR -1 04/16/25, 05:33

    on it

    icons.ts:146

    Only needs to be `async` if it actually uses await.

    PageRenderer.php:1460

    The cache identifier would only be set if there are other BE settings (currently they are always there, but we should apply it without a condition.

    PageRenderer.php:1462

    This would overwrite any existing array structure named `cache`.
  14. Benjamin Franzke uploaded patch set 6 CR -1 V +1 04/16/25, 05:45

  15. Benjamin Franzke commented on patch set 6 04/16/25, 05:45

    Reply

    There is still `getCacheIdentifierAction` in `typo3/sysext/install/Classes/Controller/IconController.php` configured by `Build/Sources/TypeScript/install/router.ts` We need to inject this setting in installtool as well..

    icons.ts:146 Reply

    Changed function body to actually use await.

    PageRenderer.php:1460 Reply

    Done

    PageRenderer.php:1462 Reply

    Done
  16. core-ci voted on patch set 6 V +1 04/16/25, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77797

  17. Benjamin Franzke uploaded patch set 7 CR -1 V +1 04/16/25, 06:14

  18. Benjamin Franzke commented on patch set 7 04/16/25, 06:14

    Reply

    Done
  19. Benjamin Franzke uploaded patch set 8 CR +1 V +1 04/16/25, 06:15

  20. core-ci voted on patch set 8 V +1 04/16/25, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77800

  21. Andreas Kienast commented on patch set 8 04/16/25, 06:29

    Thanks for taking care, @ben@bnf.dev.
  22. Stefan Bürk voted on patch set 8 CR +1 04/16/25, 07:42

  23. Stefan Bürk voted on patch set 8 V +1 04/16/25, 07:51

  24. Andreas Kienast voted on patch set 8 CR +2 V +2 04/16/25, 07:57

  25. Andreas Kienast merged patch set 9 04/16/25, 08:14