89113[TASK] Provide icon cache identifier when rendering backend
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/icons.ts2+13 −24
- Build/Sources/TypeScript/install/router.ts+0 −1
- Build/types/TYPO3/index.d.ts+3 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+0 −6
- typo3/sysext/backend/Resources/Public/JavaScript/icons.js+1 −1
- typo3/sysext/core/Classes/Controller/IconController.php+6 −32
- typo3/sysext/core/Classes/Page/PageRenderer.php4+5 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+5 −0
- typo3/sysext/install/Classes/Controller/IconController.php+0 −10
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −0
- typo3/sysext/install/Classes/Controller/LayoutController.php+3 −0
- typo3/sysext/install/Classes/ServiceProvider.php+2 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/Init.html+3 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/Init.html+4 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
Review log 1926
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 04/15/25, 07:47
-
core-ci voted on patch set 1 V -1 04/15/25, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77737
-
Andreas Kienast marked it work in progress 04/15/25, 08:02
-
Andreas Kienast uploaded patch set 2
V -104/15/25, 08:50 -
core-ci voted on patch set 2 V -1 04/15/25, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77739
-
Andreas Kienast uploaded patch set 3
V -104/15/25, 08:56 -
Andreas Kienast commented on patch set 3 04/15/25, 08:59
This change is ready for review.I'm still undecided what's the best code path to put the global assignment for the cache identifier. Putting it in BackendController and ModuleTemplate works but has two potential issues: * code is duplicated * this will break for backend modules that don't use ModuleTemplate -
core-ci voted on patch set 3 V +1 04/15/25, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77740
-
Andreas Kienast uploaded patch set 4
V +104/15/25, 09:47 -
Andreas Kienast commented on patch set 4 04/15/25, 09:47
Reply
Done -
core-ci voted on patch set 4 V -1 04/15/25, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77746
-
Andreas Kienast uploaded patch set 5
V -104/15/25, 09:55 -
core-ci voted on patch set 5 V +1 04/15/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77747
-
Benjamin Franzke commented on patch set 5 CR -1 04/16/25, 05:33
on iticons.ts:146Only needs to be `async` if it actually uses await.PageRenderer.php:1460The cache identifier would only be set if there are other BE settings (currently they are always there, but we should apply it without a condition.PageRenderer.php:1462This would overwrite any existing array structure named `cache`. -
Benjamin Franzke uploaded patch set 6
CR -1V +104/16/25, 05:45 -
Benjamin Franzke commented on patch set 6 04/16/25, 05:45
Reply
There is still `getCacheIdentifierAction` in `typo3/sysext/install/Classes/Controller/IconController.php` configured by `Build/Sources/TypeScript/install/router.ts` We need to inject this setting in installtool as well..icons.ts:146ReplyChanged function body to actually use await.PageRenderer.php:1460ReplyDonePageRenderer.php:1462ReplyDone -
core-ci voted on patch set 6 V +1 04/16/25, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77797
-
Benjamin Franzke uploaded patch set 7
CR -1V +104/16/25, 06:14 -
Benjamin Franzke commented on patch set 7 04/16/25, 06:14
Reply
Done -
Benjamin Franzke uploaded patch set 8
CR +1V +104/16/25, 06:15 -
core-ci voted on patch set 8 V +1 04/16/25, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77800
-
Andreas Kienast commented on patch set 8 04/16/25, 06:29
Thanks for taking care, @ben@bnf.dev. -
Stefan Bürk voted on patch set 8 CR +1 04/16/25, 07:42
-
Stefan Bürk voted on patch set 8 V +1 04/16/25, 07:51
-
Andreas Kienast voted on patch set 8 CR +2 V +2 04/16/25, 07:57
-
Andreas Kienast merged patch set 9 04/16/25, 08:14