Review main Merged

89116[BUGFIX] Introduce GridColumn Form element to prevent Fieldset misusage

Benjamin Kott CR +2 V +2 Normal +139 −1 updated 04/17/25, 10:56

Commit message

While Fieldset could be repurposed to define columns in
GridRows, its primary role within forms carries semantic
significance and requires a legend for proper accessibility.
Using Fieldset purely for visual structure risks misinforming
assistive technologies and disrupting user experience.

The new GridColumn element addresses these concerns by
providing a dedicated solution for grouping elements to be
presented in a column layout. It renders a simple div wrapper
with CSS classes for dimensions.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1216

  1. Benjamin Kott uploaded patch set 1 04/15/25, 12:10

  2. Benjamin Kott uploaded patch set 2 04/15/25, 12:11

  3. core-ci voted on patch set 1 V -1 04/15/25, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77752

  4. core-ci voted on patch set 2 V +1 04/15/25, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77753

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 04/16/25, 12:25

  6. Benjamin Franzke uploaded patch set 3 CR +1 V +1 04/16/25, 14:02

  7. core-ci voted on patch set 3 V +1 04/16/25, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77841

  8. Benjamin Franzke voted on patch set 3 CR +1 04/16/25, 14:12

  9. Andreas Kienast commented on patch set 3 V -1 04/16/25, 14:28

    The email output doesn't look quite right, investigating...
  10. Benjamin Kott uploaded patch set 4 CR +1 V +1 04/17/25, 09:18

  11. core-ci voted on patch set 4 V +1 04/17/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77881

  12. Benjamin Kott commented on patch set 4 04/17/25, 09:31

    Reply

    Done
  13. Benjamin Franzke voted on patch set 4 CR +1 V +1 04/17/25, 09:54

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 04/17/25, 10:17

  15. Benjamin Kott voted on patch set 4 CR +2 V +2 04/17/25, 10:47

  16. Benjamin Kott merged patch set 5 04/17/25, 10:56