Review main Merged

89121[TASK] Use proper `URL` objects in File List where applicable

Andreas Kienast CR +2 V +2 Normal +22 −31 updated 04/16/25, 05:48

Commit message

This commit replaces hand-crafted URL strings with proper URL objects
used for redirects. The URL class automatically takes care of proper
encoding and makes the code more readable.

Also, the method `parseQueryParameters()` is drastically optimized to
use native API to convert a query string to an object.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 04/15/25, 14:39

  2. core-ci voted on patch set 1 V +1 04/15/25, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77766

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 04/15/25, 19:38

  4. Benni Mack voted on patch set 1 CR +1 V +1 04/16/25, 05:25

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 04/16/25, 05:31

  6. Andreas Kienast merged patch set 2 04/16/25, 05:48