Review main Merged

89123[BUGFIX] Improve accessibility in sudo-mode modal

Benjamin Franzke CR +2 V +2 Hard +233 −104 updated 05/03/25, 08:44

Commit message

Improve accessibility for password managers by providing the
username field for user password authentication and use our
toplevel module API to cover the entire backend and re-use
our existing modal implementation, including coverage of the
entire backend instead of the module frame only.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2127

Show 2 earlier messages
  1. Benjamin Franzke uploaded patch set 1 04/15/25, 15:55

  2. Benjamin Franzke uploaded patch set 2 04/15/25, 15:58

  1. core-ci voted on patch set 1 V +1 04/15/25, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77772

  2. core-ci voted on patch set 2 V +1 04/15/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77773

  3. Benni Mack voted on patch set 2 CR +1 V +1 04/28/25, 19:33

  4. Georg Ringer voted on patch set 2 CR +1 V +1 04/28/25, 20:10

  5. Benjamin Franzke voted on patch set 2 CR +2 V +2 04/29/25, 06:42

  6. Benjamin Franzke commented on patch set 2 V 0 CR -1 04/29/25, 06:45

    sudo-mode.ts:66

  7. Benjamin Franzke uploaded patch set 3 CR +1 V +1 04/29/25, 06:49

  8. Benjamin Franzke commented on patch set 3 04/29/25, 06:49

    sudo-mode.ts:66 Reply

    Done
  9. core-ci voted on patch set 3 V +1 04/29/25, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78326

  10. Andreas Kienast commented on patch set 3 04/29/25, 07:06

    Would it make sense to disable the backdrop of the modal, so it can only get closed by clicking the "X" or "Verify"?
  11. Benjamin Franzke marked it work in progress 04/29/25, 07:18

  12. Andreas Kienast commented on patch set 3 04/29/25, 07:19

    Something is odd in Firefox: with this patch applied, submitting the form via <ENTER> is completely intercepted by the password manager (1Password in my case). This isn't an issue without the patch.
  13. Benjamin Franzke commented on patch set 3 04/29/25, 07:25

    Reply

    1password, the new IE.
  14. Benjamin Franzke uploaded patch set 4 V +1 04/29/25, 13:00

  15. Benjamin Franzke commented on patch set 4 04/29/25, 13:00

    Reply

    This was actually caused by chrome itself, because the form had not button assigned and therefore did no longer trigger submit on ENTER. Fixed, thanks!

    Reply

    I think aborting the modal is perfectly fine, but I've now improved this situation by going back to the previous module instead of residing in the blank sudo-mode dummy-module.
  16. core-ci voted on patch set 4 V -1 04/29/25, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78351

  17. core-ci commented on patch set 4 04/29/25, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78351

  18. Oliver Hader uploaded patch set 5 V -1 04/29/25, 13:26

  19. Oliver Hader commented on patch set 5 04/29/25, 13:28

    sudo-mode.ts:87

    Thx. This fixed the `Uncaught (in promise) undefined` I experienced when closing the modal... however, I still did not find out, where the error actually was triggered.
  20. Oliver Hader voted on patch set 5 CR +1 V +1 04/29/25, 13:28

  21. core-ci voted on patch set 5 V +1 04/29/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78353

  22. Benjamin Franzke commented on patch set 5 04/29/25, 16:36

    This change is ready for review.

    Reply

    Done

    sudo-mode.ts:87 Reply

    It was triggered by the rejection that `initiateSudoModeModal` produces when `'typo3:sudo-mode:verified'` has not be fired by the time the modal is closed (that means by the `'typo3:sudo-mode:finished'` event handler in line 64). I actually intended to use that for possible later API usage, but figured it's useful in this case as well. Good that it fixed that error as a side effect as well.
  23. Andreas Kienast voted on patch set 5 CR +1 V +1 04/30/25, 12:00

  24. Benjamin Franzke voted on patch set 5 CR +2 V +2 05/03/25, 08:44

  25. Benjamin Franzke merged patch set 6 05/03/25, 08:44