89123[BUGFIX] Improve accessibility in sudo-mode modal
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/security/element/sudo-mode.ts4+178 −53
- Build/Sources/TypeScript/backend/modal.ts+2 −0
- typo3/sysext/backend/Classes/Controller/Security/SudoModeController.php+17 −8
- typo3/sysext/backend/Resources/Private/Templates/SudoMode/Error.html+9 −31
- typo3/sysext/backend/Resources/Private/Templates/SudoMode/Module.html+5 −4
- typo3/sysext/backend/Resources/Public/JavaScript/security/element/sudo-mode.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/GetExtensionsCest.php+10 −3
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/InstalledExtensionsCest.php+10 −3
Review log 2127
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 04/15/25, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77772
-
core-ci voted on patch set 2 V +1 04/15/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77773
-
Benni Mack voted on patch set 2 CR +1 V +1 04/28/25, 19:33
-
Georg Ringer voted on patch set 2 CR +1 V +1 04/28/25, 20:10
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 04/29/25, 06:42
-
Benjamin Franzke commented on patch set 2 V 0 CR -1 04/29/25, 06:45
-
Benjamin Franzke uploaded patch set 3
CR +1V +104/29/25, 06:49 -
Benjamin Franzke commented on patch set 3 04/29/25, 06:49
sudo-mode.ts:66ReplyDone -
core-ci voted on patch set 3 V +1 04/29/25, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78326
-
Andreas Kienast commented on patch set 3 04/29/25, 07:06
Would it make sense to disable the backdrop of the modal, so it can only get closed by clicking the "X" or "Verify"? -
Benjamin Franzke marked it work in progress 04/29/25, 07:18
-
Andreas Kienast commented on patch set 3 04/29/25, 07:19
Something is odd in Firefox: with this patch applied, submitting the form via <ENTER> is completely intercepted by the password manager (1Password in my case). This isn't an issue without the patch. -
Benjamin Franzke commented on patch set 3 04/29/25, 07:25
Reply
1password, the new IE. -
Benjamin Franzke uploaded patch set 4
V +104/29/25, 13:00 -
Benjamin Franzke commented on patch set 4 04/29/25, 13:00
Reply
This was actually caused by chrome itself, because the form had not button assigned and therefore did no longer trigger submit on ENTER. Fixed, thanks!Reply
I think aborting the modal is perfectly fine, but I've now improved this situation by going back to the previous module instead of residing in the blank sudo-mode dummy-module. -
core-ci voted on patch set 4 V -1 04/29/25, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78351
-
core-ci commented on patch set 4 04/29/25, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78351
-
Oliver Hader uploaded patch set 5
V -104/29/25, 13:26 -
Oliver Hader commented on patch set 5 04/29/25, 13:28
sudo-mode.ts:87Thx. This fixed the `Uncaught (in promise) undefined` I experienced when closing the modal... however, I still did not find out, where the error actually was triggered. -
Oliver Hader voted on patch set 5 CR +1 V +1 04/29/25, 13:28
-
core-ci voted on patch set 5 V +1 04/29/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78353
-
Benjamin Franzke commented on patch set 5 04/29/25, 16:36
This change is ready for review.Reply
Donesudo-mode.ts:87ReplyIt was triggered by the rejection that `initiateSudoModeModal` produces when `'typo3:sudo-mode:verified'` has not be fired by the time the modal is closed (that means by the `'typo3:sudo-mode:finished'` event handler in line 64). I actually intended to use that for possible later API usage, but figured it's useful in this case as well. Good that it fixed that error as a side effect as well. -
Andreas Kienast voted on patch set 5 CR +1 V +1 04/30/25, 12:00
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 05/03/25, 08:44
-
Benjamin Franzke merged patch set 6 05/03/25, 08:44
sudo-mode.ts:66