Review main Merged

89132[BUGFIX] Always render form element icons inline

Georg Ringer CR +2 V +2 Easy +1 −1 updated 04/16/25, 09:29

Commit message

To improve the visbility of icons of form elements the rendering
must be changed to `inline`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 04/16/25, 08:06

  2. Georg Ringer commented on patch set 1 04/16/25, 08:06

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/16/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77811

  4. Benjamin Kott voted on patch set 1 CR +1 V +1 04/16/25, 08:49

  5. Oli Bartsch commented on patch set 1 04/16/25, 09:01

    FormEngineUtility.php:156

    Should we use MARKUP_IDENTIFIER_INLINE constant here?
  6. Andreas Kienast commented on patch set 1 CR -1 04/16/25, 09:21

    FormEngineUtility.php:156 Reply

    Yes, please
  7. Andreas Kienast commented on patch set 1 CR +2 V +2 04/16/25, 09:23

    FormEngineUtility.php:156 Reply

    Ah now, the constants are specific to the icon providers...
  8. Andreas Kienast commented on patch set 1 04/16/25, 09:23

    FormEngineUtility.php:156 Reply

    Done
  9. Andreas Kienast merged patch set 2 04/16/25, 09:29