Review 13.4 Merged

89134[BUGFIX] Only return FAL folder as fallback storage when it is a real directory

Benni Mack CR +2 V +2 Easy +14 −10 updated 04/16/25, 09:24

Commit message

This change adapts to return NULL when
trying to resolve a FAL resource (File or Folder),
instead of falling back to a Folder object,
even if the folder does not exist.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 711

  1. Benni Mack commented on patch set 1 04/16/25, 09:08

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/ResourceFactory.php
  2. Benni Mack commented on patch set 2 04/16/25, 09:08

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 04/16/25, 09:09

  4. Georg Ringer uploaded patch set 3 04/16/25, 09:12

  5. Georg Ringer uploaded patch set 4 04/16/25, 09:16

  6. core-ci voted on patch set 1 V +1 04/16/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77816

  7. core-ci voted on patch set 2 V +1 04/16/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77817

  8. core-ci voted on patch set 3 V -1 04/16/25, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77818

  9. core-ci voted on patch set 4 V +1 04/16/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77819

  10. Benni Mack voted on patch set 4 CR +2 V +2 04/16/25, 09:24

  11. Benni Mack merged patch set 5 04/16/25, 09:24