89139[BUGFIX] Restore nested `CompositeExpression` performance
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1725
-
Stefan Bürk uploaded patch set 1 04/16/25, 11:12
-
core-ci voted on patch set 1 V +1 04/16/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77829
-
Stefan Bürk updated the commit message in patch set 2
V +104/16/25, 14:49 -
core-ci voted on patch set 2 V +1 04/16/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77845
-
Stefan Bürk uploaded patch set 3
V +104/16/25, 16:08 -
core-ci voted on patch set 3 V +1 04/16/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77846
-
Garvin Hicking commented on patch set 3 04/16/25, 16:34
CompositeExpression.php:156"then" > "when"?CompositeExpression.php:157author > authors -
Stefan Bürk uploaded patch set 4
V +104/16/25, 17:11 -
Stefan Bürk commented on patch set 4 04/16/25, 17:12
CompositeExpression.php:152ReplyRephases the comment. Trade-off was not the intention.CompositeExpression.php:156ReplyDoneCompositeExpression.php:157ReplyDone -
core-ci voted on patch set 4 V +1 04/16/25, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77850
-
Stefan Bürk uploaded patch set 5
V +104/17/25, 11:39 -
core-ci voted on patch set 5 V -1 04/17/25, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77890
-
Stefan Bürk uploaded patch set 6
V -104/17/25, 11:49 -
core-ci voted on patch set 6 V +1 04/17/25, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77891
-
Daniel Siepmann commented on patch set 6 V +1 04/17/25, 11:59
verified as composer patch on instance -
core-ci commented on patch set 6 04/17/25, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77892
-
Georg Ringer voted on patch set 6 CR +1 V +1 04/17/25, 13:20
-
Benni Mack updated the commit message in patch set 7
CR +1V +104/17/25, 13:35 -
core-ci voted on patch set 7 V +1 04/17/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77893
-
Georg Ringer voted on patch set 7 CR +1 V +1 04/17/25, 13:42
-
Garvin Hicking commented on patch set 7 CR +1 V +1 04/17/25, 13:58
yay! :-) -
Stefan Bürk commented on patch set 7 CR -1 04/17/25, 14:00
Thanks for votes, -1 as it seems Benni is reviewing and waiting if he finds something. -
Benni Mack voted on patch set 7 CR +1 V +1 04/17/25, 15:45
-
Stefan Bürk voted on patch set 7 CR +2 V +2 04/17/25, 15:51
-
Stefan Bürk merged patch set 8 04/17/25, 15:59
CompositeExpression.php:152