89141[TASK] Playwright fixture: Listen to events
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 4
Review log 1319
-
Jochen Roth uploaded patch set 1 04/16/25, 11:41
-
Jochen Roth uploaded patch set 2 04/16/25, 11:42
-
core-ci voted on patch set 2 V +1 04/16/25, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77833
-
core-ci voted on patch set 1 V +1 04/16/25, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77831
-
Jochen Roth uploaded patch set 3
V +104/16/25, 12:47 -
core-ci voted on patch set 3 V +1 04/16/25, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77837
-
Jochen Roth commented on patch set 3 04/16/25, 17:17
-
Jochen Roth uploaded patch set 4
V +104/17/25, 19:27 -
core-ci voted on patch set 4 V +1 04/17/25, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77905
-
Christian Kuhn voted on patch set 4 CR +1 V +1 04/23/25, 10:10
-
Andreas Kienast commented on patch set 4 CR +1 04/23/25, 13:00
Unresolved
Looks fine for me, but I'd like to get additional feedback from @ben@bnf.dev. -
Andreas Kienast commented on patch set 4 04/23/25, 13:34
page-tree.ts:155Reply UnresolvedYou could listen to the `typo3-module-loaded` event. -
Andreas Kienast commented on patch set 4 CR -1 04/23/25, 13:55
tree.ts:693UnresolvedBeware: `changedProperties` contains the *old* state, thus `changedProperties.get('loading') === false` means it became `true` now. You may check for something like this: ``` if (changedProperties.has('loading') && this.loading) { // yadda yadda } ``` -
Jochen Roth uploaded patch set 5
CR +1V +110/20/25, 13:35 -
core-ci voted on patch set 5 V -1 10/20/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87082
-
Benni Mack updated the commit message in patch set 6
V -104/22/26, 06:31 -
core-ci voted on patch set 6 V -1 04/22/26, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100719
-
Christian Kuhn wrote 06/18/26, 23:07
Removed reviewer Christian Kuhn. -
Jochen Roth abandoned the change 07/15/26, 10:24
Not needed anymore
page-tree.ts:155