Review main Abandoned

89141[TASK] Playwright fixture: Listen to events

Jochen Roth CR 0 V -1 Normal +71 −38 updated 07/15/26, 10:24

Commit message

Currently, playwright fixtures rely on elements
to be visible/hidden on the page.

This has been changed to listen to events
instead and therefore the new Event "tree:loaded"
was introduced.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 4

Review log 1319

  1. Jochen Roth uploaded patch set 1 04/16/25, 11:41

  2. Jochen Roth uploaded patch set 2 04/16/25, 11:42

  3. core-ci voted on patch set 2 V +1 04/16/25, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77833

  4. core-ci voted on patch set 1 V +1 04/16/25, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77831

  5. Jochen Roth uploaded patch set 3 V +1 04/16/25, 12:47

  6. core-ci voted on patch set 3 V +1 04/16/25, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77837

  7. Jochen Roth commented on patch set 3 04/16/25, 17:17

    page-tree.ts:155

    @benjamin.kott@outlook.com not other event worked in this case. In case you have any suggestions to use a event instead i would be happy to hear.
  8. Jochen Roth uploaded patch set 4 V +1 04/17/25, 19:27

  9. core-ci voted on patch set 4 V +1 04/17/25, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77905

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 04/23/25, 10:10

  11. Andreas Kienast commented on patch set 4 CR +1 04/23/25, 13:00

    Unresolved

    Looks fine for me, but I'd like to get additional feedback from @ben@bnf.dev.
  12. Andreas Kienast commented on patch set 4 04/23/25, 13:34

    page-tree.ts:155 Reply Unresolved

    You could listen to the `typo3-module-loaded` event.
  13. Andreas Kienast commented on patch set 4 CR -1 04/23/25, 13:55

    tree.ts:693 Unresolved

    Beware: `changedProperties` contains the *old* state, thus `changedProperties.get('loading') === false` means it became `true` now. You may check for something like this: ``` if (changedProperties.has('loading') && this.loading) { // yadda yadda } ```
  14. Jochen Roth uploaded patch set 5 CR +1 V +1 10/20/25, 13:35

  15. core-ci voted on patch set 5 V -1 10/20/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87082

  16. Benni Mack updated the commit message in patch set 6 V -1 04/22/26, 06:31

  17. core-ci voted on patch set 6 V -1 04/22/26, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100719

  18. Christian Kuhn wrote 06/18/26, 23:07

    Removed reviewer Christian Kuhn.
  19. Jochen Roth abandoned the change 07/15/26, 10:24

    Not needed anymore