89144[BUGFIX] Execute `bulkInsert()` in chunks for larger datasets
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1317
-
Oliver Heins uploaded patch set 1 04/16/25, 12:47
-
core-ci voted on patch set 1 V +1 04/16/25, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77838
-
Georg Ringer commented on patch set 1 04/16/25, 15:26
Connection.php:254can't we use code like added in https://github.com/typo3/typo3/commit/07c9e36d75fba4157d25202808b60ac0fd2d32f9? -
Stefan Bürk commented on patch set 1 CR -1 04/16/25, 16:37
On it ... reviewing/testing/changing ...Connection.php:211ReplyEither chunkSize should be handed from the outside or calculated internally. As this is a change in signature, not breaking I would abstain from making this option passed and instead calculate the chunks everytime. There should be no need to change that from the outside. If that is needed, calling code can do the chunk on themself and add chunked $data directly. -
Stefan Bürk uploaded patch set 2
CR -1V +104/16/25, 17:07 -
core-ci voted on patch set 2 V -1 04/16/25, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77848
-
Stefan Bürk uploaded patch set 3
V -104/16/25, 17:43 -
Stefan Bürk commented on patch set 3 04/16/25, 17:43
Reply
DoneConnection.php:211ReplyRemoved the new argument again.Connection.php:254ReplyAck. -
core-ci voted on patch set 3 V +1 04/16/25, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77853
-
Stefan Bürk commented on patch set 3 04/16/25, 17:54
Thanks @o.heins@leuchtfeuer.com for this fix. ❤️ -
Stefan Bürk voted on patch set 3 CR +1 V +1 04/16/25, 17:54
-
Stefan Bürk updated the commit message in patch set 4
CR +1V +104/16/25, 18:07 -
Stefan Bürk voted on patch set 4 CR +1 V +1 04/16/25, 18:07
-
core-ci voted on patch set 4 V +1 04/16/25, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77854
-
Georg Ringer voted on patch set 4 CR +1 V +1 04/16/25, 18:25
-
Stefan Bürk voted on patch set 4 CR +2 V +2 04/16/25, 18:57
-
Stefan Bürk merged patch set 5 04/16/25, 19:59
Connection.php:211