Review main Merged

89146[TASK] Update phpstan

Wouter Wolters CR +2 V +2 Easy +37 −8 updated 04/17/25, 08:44

Commit message

Used commands:

> composer req --dev phpstan/phpstan:^2.1.12
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 810

  1. Wouter Wolters uploaded patch set 1 04/16/25, 17:08

  2. core-ci voted on patch set 1 V -1 04/16/25, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77849

  3. Wouter Wolters uploaded patch set 2 V -1 04/16/25, 17:31

  4. core-ci voted on patch set 2 V +1 04/16/25, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77852

  5. Stefan Bürk commented on patch set 2 04/16/25, 17:52

    I'm curious which change in phpstan fixed the `memcache_close()` .. we added that just recently .... @typo3@wouterwolters.nl Do you know which commit/pr fixed that ?
  6. Stefan Bürk voted on patch set 2 CR +1 V +1 04/16/25, 19:44

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/16/25, 20:04

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 04/16/25, 20:09

  9. Stefan Bürk merged patch set 3 04/16/25, 20:19

  10. Stefan Bürk commented on patch set 3 04/17/25, 08:44

    Adding late backport also to 12.4