Review main Merged

89157[BUGFIX] Include computed properties in CObject ViewHelper

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/18/25, 08:59

Commit message

Since some data processors, e.g. FilesProcessor, as well
as any other content rendering related functionality
might need to access computed properties, such as
the localized uid, corresponding properties are now
included in the data array.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1316

  1. Georg Ringer uploaded patch set 1 04/17/25, 13:47

  2. Georg Ringer commented on patch set 1 04/17/25, 13:48

    This change is ready for review.
  3. Benni Mack commented on patch set 1 CR -1 04/17/25, 13:54

    I don't know how to reproduce this. I am really confident we need to fix this in Collector instead... but I tried to re-build this in main.... I need halp!
  4. core-ci voted on patch set 1 V -1 04/17/25, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77894

  5. Oli Bartsch commented on patch set 1 04/17/25, 14:25

    Reply

    Will look into it.
  6. Oli Bartsch uploaded patch set 2 CR -1 V -1 04/17/25, 15:00

  7. Oli Bartsch commented on patch set 2 04/17/25, 15:02

    Reply

    Could reproduce following the steps in the issue. its important to render the content elements via the CObject ViewHelper. I've adjusted the place to include computed properties and let the file collector use them properly.
  8. core-ci voted on patch set 2 V +1 04/17/25, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77896

  9. Benni Mack voted on patch set 2 CR +1 04/17/25, 15:43

  10. Benni Mack updated the commit message in patch set 3 CR +1 V +1 04/17/25, 15:43

  11. core-ci voted on patch set 3 V +1 04/17/25, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77898

  12. Benni Mack voted on patch set 3 CR +1 V +1 04/17/25, 16:34

  13. Garvin Hicking voted on patch set 3 CR +1 04/17/25, 16:44

  14. Georg Ringer voted on patch set 3 CR +1 V +1 04/18/25, 08:36

  15. Oli Bartsch voted on patch set 3 CR +2 V +2 04/18/25, 08:59

  16. Oli Bartsch merged patch set 4 04/18/25, 08:59