Review main Merged

89165[TASK] Playwright: Migrate DbCheckModuleCest

Jochen Roth CR +2 V +2 Normal +28 −54 updated 11/22/25, 20:49

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 4582

Show 2957 earlier messages
  1. Jochen Roth uploaded patch set 1 04/17/25, 22:43

  2. core-ci voted on patch set 1 V +1 04/17/25, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77910

  3. Jochen Roth uploaded patch set 2 V +1 11/20/25, 22:24

  4. Jochen Roth uploaded patch set 3 11/20/25, 22:27

  5. Jochen Roth uploaded patch set 4 11/20/25, 22:27

  6. Jochen Roth uploaded patch set 5 11/20/25, 22:27

  7. core-ci voted on patch set 2 V +1 11/20/25, 22:35 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3, 4, 5 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90404

  8. core-ci voted on patch set 3 V +1 11/20/25, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90405

  9. core-ci voted on patch set 4 V +1 11/20/25, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90406

  10. core-ci voted on patch set 5 V +1 11/20/25, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90407

  11. Jochen Roth uploaded patch set 6 V +1 11/21/25, 13:15

  12. Jochen Roth uploaded patch set 7 11/21/25, 13:16

  13. Jochen Roth uploaded patch set 8 11/21/25, 13:16

  14. Jochen Roth uploaded patch set 9 11/21/25, 13:16

  15. Jochen Roth uploaded patch set 10 11/21/25, 13:16

  16. Jochen Roth uploaded patch set 11 11/21/25, 13:16

  17. Jochen Roth uploaded patch set 12 11/21/25, 13:16

  18. Jochen Roth uploaded patch set 13 11/21/25, 13:17

  19. Jochen Roth uploaded patch set 14 11/21/25, 13:17

  20. Jochen Roth uploaded patch set 15 11/21/25, 13:17

  21. Jochen Roth uploaded patch set 16 11/21/25, 13:17

  22. Jochen Roth uploaded patch set 17 11/21/25, 13:18

  23. Jochen Roth uploaded patch set 18 11/21/25, 13:18

  24. Jochen Roth uploaded patch set 19 11/21/25, 13:18

  25. Jochen Roth uploaded patch set 20 11/21/25, 13:18

  26. Jochen Roth uploaded patch set 21 11/21/25, 13:18

  27. Jochen Roth uploaded patch set 22 11/21/25, 13:18

  28. Jochen Roth uploaded patch set 23 11/21/25, 13:19

  29. Jochen Roth uploaded patch set 24 11/21/25, 13:19

  30. Jochen Roth uploaded patch set 25 11/21/25, 13:19

  31. Jochen Roth uploaded patch set 26 11/21/25, 13:19

  32. Jochen Roth uploaded patch set 27 11/21/25, 13:19

  33. core-ci voted on patch set 6 V +1 11/21/25, 13:27 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90503

  34. core-ci voted on patch set 8 V +1 11/21/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90505

  35. core-ci voted on patch set 9 V +1 11/21/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90506

  36. core-ci voted on patch set 7 V -1 11/21/25, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90504

  37. core-ci voted on patch set 10 V +1 11/21/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90507

  38. core-ci voted on patch set 11 V +1 11/21/25, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90508

  39. core-ci voted on patch set 12 V +1 11/21/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90509

  40. core-ci voted on patch set 14 V +1 11/21/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90511

  41. core-ci voted on patch set 15 V +1 11/21/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90512

  42. core-ci voted on patch set 16 V +1 11/21/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90513

  43. core-ci voted on patch set 18 V +1 11/21/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90515

  44. core-ci voted on patch set 19 V +1 11/21/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90516

  45. core-ci voted on patch set 20 V +1 11/21/25, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90517

  46. core-ci voted on patch set 21 V +1 11/21/25, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90518

  47. core-ci voted on patch set 22 V +1 11/21/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90519

  48. core-ci voted on patch set 13 V +1 11/21/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90510

  49. core-ci voted on patch set 17 V +1 11/21/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90514

  50. core-ci voted on patch set 23 V +1 11/21/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90520

  51. core-ci voted on patch set 24 V +1 11/21/25, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90521

  52. core-ci voted on patch set 25 V +1 11/21/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90522

  53. core-ci voted on patch set 26 V -1 11/21/25, 13:58 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 27 (was Verified+1) (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90523

  54. core-ci voted on patch set 27 V +1 11/21/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90524

  55. Jochen Roth uploaded patch set 28 V +1 11/22/25, 14:39

  56. core-ci voted on patch set 28 V -1 11/22/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90649

  57. Jochen Roth uploaded patch set 29 V -1 11/22/25, 15:37

  1. core-ci voted on patch set 29 V -1 11/22/25, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90653

  2. Jochen Roth uploaded patch set 30 V -1 11/22/25, 16:35

  3. Jochen Roth uploaded patch set 31 11/22/25, 16:36

  4. Jochen Roth uploaded patch set 32 11/22/25, 16:36

  5. Jochen Roth uploaded patch set 33 11/22/25, 16:36

  6. Sven Liebert commented on patch set 30 11/22/25, 16:39

    db-check-module.spec.ts:3

    could we name the directory like the module? so it would be database/database-module.spec.ts? Before your test I didn't noticed the module asked myself where to find the module from the test (it's not really direct clear because of our goToModule fixture with non-speaking naming)

    DbCheckModuleCest.php:3

    This is only emptied but not deleted.
  7. core-ci voted on patch set 31 V -1 11/22/25, 16:45 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 32, 33 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90663

  8. core-ci voted on patch set 30 V -1 11/22/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90662

  9. core-ci voted on patch set 32 V -1 11/22/25, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90664

  10. core-ci voted on patch set 33 V -1 11/22/25, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90665

  11. Jochen Roth uploaded patch set 34 V -1 11/22/25, 16:53

  12. Jochen Roth uploaded patch set 35 11/22/25, 16:54

  13. Jochen Roth commented on patch set 35 11/22/25, 16:57

    db-check-module.spec.ts:3 Reply

    Acknowledged

    DbCheckModuleCest.php:3 Reply

    Acknowledged
  14. core-ci voted on patch set 34 V +1 11/22/25, 17:04 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 35 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90667

  15. core-ci voted on patch set 35 V +1 11/22/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90668

  16. Sven Liebert commented on patch set 35 11/22/25, 17:27

    database-module.spec.ts:3

    ```suggestion test.describe('Database Module', () => { ```
  17. Christian Kuhn uploaded patch set 36 V +1 11/22/25, 18:54

  18. Sven Liebert commented on patch set 36 CR +1 V +1 11/22/25, 19:01

    database-module.spec.ts:3 Reply

    Done
  19. core-ci voted on patch set 36 V +1 11/22/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90680

  20. Christian Kuhn uploaded patch set 37 CR +1 V +1 11/22/25, 19:27

  21. Christian Kuhn voted on patch set 37 CR +1 V +1 11/22/25, 19:28

  22. Sven Liebert voted on patch set 37 CR +1 V +1 11/22/25, 19:34

  23. core-ci voted on patch set 37 V +1 11/22/25, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90686

  24. Christian Kuhn voted on patch set 37 CR +2 V +2 11/22/25, 20:49

  25. Christian Kuhn merged patch set 38 11/22/25, 20:49