Review main Merged

89175[TASK] Playwright: Migrate BackendUser/* tests

Jochen Roth CR +2 V +2 Expert +575 −478 updated 11/19/25, 21:16

Commit message

* Migrate BackendUser module tests to playwright
* Update playwright to ^1.55.0
* Add form-engine fixture

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 79155

Show 67130 earlier messages
  1. Jochen Roth uploaded patch set 1 04/19/25, 18:24

  2. core-ci voted on patch set 1 V -1 04/19/25, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77960

  3. Jochen Roth uploaded patch set 2 V -1 09/05/25, 14:14

  4. core-ci voted on patch set 2 V -1 09/05/25, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84473

  5. Jochen Roth uploaded patch set 3 V -1 09/08/25, 11:01

  6. core-ci voted on patch set 3 V -1 09/08/25, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84617

  7. Jochen Roth uploaded patch set 4 V -1 09/08/25, 12:20

  8. core-ci voted on patch set 4 V -1 09/08/25, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84625

  9. core-ci commented on patch set 4 09/08/25, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84625

  10. Jochen Roth uploaded patch set 5 V -1 09/08/25, 13:44

  11. core-ci voted on patch set 5 V -1 09/08/25, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84630

  12. Jochen Roth uploaded patch set 6 V -1 09/08/25, 14:50

  13. core-ci voted on patch set 6 V -1 09/08/25, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84632

  14. Jochen Roth uploaded patch set 7 V -1 09/08/25, 15:01

  15. Jochen Roth uploaded patch set 8 09/08/25, 15:06

  16. core-ci voted on patch set 7 V -1 09/08/25, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84633

  17. core-ci voted on patch set 8 V -1 09/08/25, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84634

  18. Jochen Roth uploaded patch set 9 V -1 09/08/25, 16:19

  19. core-ci voted on patch set 9 V -1 09/08/25, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84635

  20. Jochen Roth uploaded patch set 10 V -1 09/08/25, 19:07

  21. core-ci voted on patch set 10 V +1 09/08/25, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84640

  22. core-ci voted on patch set 10 V -1 09/08/25, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84640

  23. Jochen Roth uploaded patch set 11 V -1 09/09/25, 13:48

  24. core-ci voted on patch set 11 V +1 09/09/25, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84708

  25. Jochen Roth uploaded patch set 12 V +1 09/09/25, 14:16

  26. core-ci voted on patch set 12 V +1 09/09/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84712

  27. core-ci commented on patch set 12 09/09/25, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84712

  28. core-ci commented on patch set 12 09/09/25, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84712

  29. core-ci voted on patch set 12 V -1 09/09/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84712

  30. Jochen Roth uploaded patch set 13 V -1 09/10/25, 10:59

  31. core-ci voted on patch set 13 V +1 09/10/25, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  32. core-ci voted on patch set 13 V -1 09/10/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  33. core-ci voted on patch set 13 V +1 09/10/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  34. core-ci commented on patch set 13 09/10/25, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  35. core-ci commented on patch set 13 09/10/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  36. core-ci voted on patch set 13 V -1 09/10/25, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  37. core-ci commented on patch set 13 09/10/25, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84772

  38. Jochen Roth uploaded patch set 14 V -1 10/20/25, 11:26

  39. core-ci voted on patch set 14 V +1 10/20/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87070

  40. Jochen Roth updated the commit message in patch set 15 V +1 10/20/25, 11:53

  41. core-ci voted on patch set 15 V +1 10/20/25, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87072

  42. Jochen Roth uploaded patch set 16 10/20/25, 12:06

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  43. core-ci voted on patch set 16 V +1 10/20/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87075

  44. Jochen Roth uploaded patch set 17 10/20/25, 12:32

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  45. core-ci voted on patch set 17 V +1 10/20/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87077

  46. core-ci commented on patch set 17 10/20/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87077

  47. Jochen Roth updated the commit message in patch set 18 V +1 10/20/25, 13:02

  48. core-ci voted on patch set 18 V +1 10/20/25, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87079

  49. Jochen Roth uploaded patch set 19 10/20/25, 13:15

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  50. Jochen Roth commented on patch set 19 10/20/25, 13:18

    Would be great if you could have a look.
  51. core-ci voted on patch set 19 V +1 10/20/25, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87081

  52. Sven Liebert voted on patch set 19 CR +1 V +1 10/21/25, 15:36

  53. Jochen Roth uploaded patch set 20 CR +1 V +1 11/10/25, 23:17

  54. Jochen Roth commented on patch set 20 CR -1 11/10/25, 23:17

    Still on it
  55. core-ci voted on patch set 20 V +1 11/10/25, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88919

  56. Jochen Roth uploaded patch set 21 CR -1 V +1 11/16/25, 14:31

  57. core-ci voted on patch set 21 V +1 11/16/25, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89860

  58. Jochen Roth commented on patch set 21 11/16/25, 14:40

    Reply

    doen
  59. Sven Liebert voted on patch set 21 CR +1 V +1 11/16/25, 19:38

  60. Oliver Klee voted on patch set 21 V +1 11/16/25, 21:39

  61. Christian Kuhn commented on patch set 21 11/17/25, 11:29

    latest run had "1 flaky": https://git.typo3.org/typo3/CI/cms/-/jobs/5014739#L400 how to deal with that? have a look now, or do it later, or just wait if that materializes in instability?
    imho main only: we had other patches not backported already, and avoiding codeception in v13 is "too late" and eats too much precious developers time away.
  62. Sven Liebert commented on patch set 21 CR 0 V 0 11/17/25, 11:37

    Reply

    Would look later, because we need to use and test the formEngine helpers more and more.

    Reply

    Not only in your opinion. I just overlooked that in my review.
  63. Jochen Roth uploaded patch set 22 V +1 11/17/25, 20:03

  64. core-ci voted on patch set 22 V -1 11/17/25, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89964

  65. core-ci voted on patch set 22 V +1 11/17/25, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89964

  66. Oliver Klee voted on patch set 22 V +1 11/17/25, 20:17

  67. core-ci commented on patch set 22 11/17/25, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89964

  68. Jochen Roth uploaded patch set 23 V +1 11/17/25, 20:55

  69. core-ci voted on patch set 23 V +1 11/17/25, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89967

  70. Jochen Roth uploaded patch set 24 V +1 11/17/25, 21:21

  71. Jochen Roth uploaded patch set 25 11/17/25, 21:21

  72. Jochen Roth uploaded patch set 26 11/17/25, 21:22

  73. Jochen Roth uploaded patch set 27 11/17/25, 21:22

  74. Jochen Roth uploaded patch set 28 11/17/25, 21:23

  75. core-ci voted on patch set 25 V +1 11/17/25, 21:32 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 26, 27, 28 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89969

  76. core-ci voted on patch set 27 V +1 11/17/25, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89971

  77. core-ci voted on patch set 24 V +1 11/17/25, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89968

  78. core-ci voted on patch set 26 V -1 11/17/25, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89970

  79. core-ci voted on patch set 28 V +1 11/17/25, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89972

  80. Christian Kuhn commented on patch set 28 11/17/25, 22:48

    Reply

    Done

    Reply

    Done
  81. Christian Kuhn commented on patch set 28 11/17/25, 22:50

    jochen still actively working on it.
  82. Jochen Roth commented on patch set 28 CR -1 11/17/25, 22:52

    Will need to do more testing. See a few pipelines running in parallel. Success with 4 out of 5 is not enough
  83. Jochen Roth uploaded patch set 29 CR -1 V +1 11/19/25, 15:00

  84. Jochen Roth uploaded patch set 30 11/19/25, 15:01

  85. Jochen Roth uploaded patch set 31 11/19/25, 15:01

  86. Jochen Roth uploaded patch set 32 11/19/25, 15:01

  87. Jochen Roth uploaded patch set 33 11/19/25, 15:01

  88. Jochen Roth uploaded patch set 34 11/19/25, 15:02

  89. Jochen Roth uploaded patch set 35 11/19/25, 15:02

  90. Jochen Roth uploaded patch set 36 11/19/25, 15:02

  91. Jochen Roth uploaded patch set 37 11/19/25, 15:02

  92. Jochen Roth uploaded patch set 38 11/19/25, 15:02

  93. Jochen Roth uploaded patch set 39 11/19/25, 15:03

  94. Jochen Roth uploaded patch set 40 11/19/25, 15:03

  95. Jochen Roth uploaded patch set 41 11/19/25, 15:03

  96. Jochen Roth uploaded patch set 42 11/19/25, 15:04

  97. Jochen Roth uploaded patch set 43 11/19/25, 15:04

  98. Jochen Roth uploaded patch set 44 11/19/25, 15:04

  99. core-ci voted on patch set 29 V +1 11/19/25, 15:13 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90141

  100. core-ci voted on patch set 30 V +1 11/19/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90142

  101. core-ci voted on patch set 32 V +1 11/19/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90144

  102. core-ci voted on patch set 33 V +1 11/19/25, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90145

  103. core-ci voted on patch set 34 V +1 11/19/25, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90146

  104. core-ci voted on patch set 31 V +1 11/19/25, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90143

  105. core-ci voted on patch set 35 V +1 11/19/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90147

  106. core-ci voted on patch set 37 V +1 11/19/25, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90149

  107. core-ci voted on patch set 38 V +1 11/19/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90150

  108. core-ci voted on patch set 39 V +1 11/19/25, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90151

  109. core-ci voted on patch set 36 V +1 11/19/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90148

  110. core-ci voted on patch set 40 V +1 11/19/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90152

  111. core-ci voted on patch set 41 V +1 11/19/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90153

  112. core-ci voted on patch set 42 V +1 11/19/25, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90154

  113. core-ci voted on patch set 43 V +1 11/19/25, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90155

  114. core-ci voted on patch set 44 V +1 11/19/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90156

  115. Oliver Klee wrote 11/19/25, 15:40

    Removed reviewer Oliver Klee.
  116. Jochen Roth uploaded patch set 45 V +1 11/19/25, 15:40

  117. Jochen Roth uploaded patch set 46 11/19/25, 15:40

  118. Jochen Roth uploaded patch set 47 11/19/25, 15:40

  119. Jochen Roth uploaded patch set 48 11/19/25, 15:40

  120. Jochen Roth uploaded patch set 49 11/19/25, 15:40

  121. core-ci voted on patch set 45 V +1 11/19/25, 15:51 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 46, 47, 48, 49 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90163

  122. core-ci voted on patch set 46 V +1 11/19/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90164

  123. core-ci voted on patch set 47 V +1 11/19/25, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90165

  124. core-ci voted on patch set 48 V +1 11/19/25, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90166

  125. core-ci voted on patch set 49 V +1 11/19/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90167

  126. Jochen Roth uploaded patch set 50 V +1 11/19/25, 18:20

  127. Jochen Roth uploaded patch set 51 11/19/25, 18:20

  128. Jochen Roth uploaded patch set 52 11/19/25, 18:20

  129. Jochen Roth uploaded patch set 53 11/19/25, 18:20

  130. Jochen Roth uploaded patch set 54 11/19/25, 18:21

  1. Jochen Roth uploaded patch set 55 11/19/25, 18:21

  2. core-ci voted on patch set 50 V +1 11/19/25, 18:32 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 51, 52, 53, 54, 55 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90184

  3. core-ci voted on patch set 51 V +1 11/19/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90185

  4. core-ci voted on patch set 53 V +1 11/19/25, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90187

  5. core-ci voted on patch set 52 V +1 11/19/25, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90186

  6. core-ci voted on patch set 54 V +1 11/19/25, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90188

  7. core-ci voted on patch set 55 V +1 11/19/25, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90189

  8. Jochen Roth uploaded patch set 56 V +1 11/19/25, 18:54

  9. Jochen Roth uploaded patch set 57 11/19/25, 18:55

  10. Jochen Roth uploaded patch set 58 11/19/25, 18:55

  11. Jochen Roth uploaded patch set 59 11/19/25, 18:55

  12. core-ci voted on patch set 57 V +1 11/19/25, 19:05 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 58, 59 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90192

  13. core-ci voted on patch set 56 V +1 11/19/25, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90191

  14. core-ci voted on patch set 58 V +1 11/19/25, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90193

  15. core-ci voted on patch set 59 V +1 11/19/25, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90194

  16. Jochen Roth uploaded patch set 60 V +1 11/19/25, 19:10

  17. core-ci voted on patch set 60 V +1 11/19/25, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90195

  18. Christian Kuhn commented on patch set 60 CR +1 V +1 11/19/25, 20:14

    mega! thank you so much!
  19. Christian Kuhn updated the commit message in patch set 61 CR +1 V +1 11/19/25, 20:15

  20. Christian Kuhn voted on patch set 61 CR +1 V +1 11/19/25, 20:15

  21. core-ci voted on patch set 61 V +1 11/19/25, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90198

  22. Sven Liebert voted on patch set 61 CR +1 V +1 11/19/25, 20:37

  23. Christian Kuhn voted on patch set 61 CR +2 V +2 11/19/25, 21:00

  24. core-ci commented on patch set 61 11/19/25, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90201

  25. Christian Kuhn merged patch set 62 11/19/25, 21:16