Review main Merged

89176[BUGFIX] Check page permissions in page's language mode

Georg Ringer CR +2 V +2 Easy +3 −1 updated 04/28/25, 19:57

Commit message

If a page is not allowed to be edited, the same checks need to be
applied to the language mode as the mode "Layout".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 04/20/25, 14:30

  2. Georg Ringer commented on patch set 1 04/20/25, 14:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/20/25, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77975

  4. Oli Bartsch commented on patch set 1 04/28/25, 15:41

    This works but I wonder if we should not just add $this->getBackendUser()->doesUserHaveAccess($this->context->getPageRecord(), Permission::PAGE_EDIT) in LanguageColumn->getAllowEditPage(). What do you think?
  5. Oli Bartsch uploaded patch set 2 V +1 04/28/25, 15:42

  6. Oli Bartsch commented on patch set 2 04/28/25, 15:43

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 04/28/25, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78290

  8. Benni Mack voted on patch set 2 CR +1 V +1 04/28/25, 19:53

  9. Georg Ringer voted on patch set 2 CR +1 V +1 04/28/25, 19:55

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 04/28/25, 19:57

  11. Oli Bartsch merged patch set 3 04/28/25, 19:57