Review main Ready for review

89177[BUGFIX] Never cache an empty backend icon registry

Georg Ringer CR +1 V +1 Normal +100 −26 updated 11/15/26, 16:59

Commit message

IconRegistry silently accepted a broken icon declaration: if
icons.json could not be read, json_decode() returned null, no
icon was registered, and the resulting empty array was written
to the assets cache. As the static icon list is empty as well,
the following sanity check considered this a success.

From then on every request failed with "Icon with identifier
default-not-found is not registered" until all caches were
flushed manually.

The icon declaration and the flag folder are now read strictly
and throw an exception if they are unreadable or contain no
icon, so an empty result can no longer end up in the cache. An
already cached empty array is treated as a cache miss, which
lets affected installations recover on their own.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/89177/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/89177/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1319

  1. Georg Ringer uploaded patch set 1 04/21/25, 06:38

  2. Georg Ringer commented on patch set 1 04/21/25, 06:38

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 04/21/25, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77991

  4. Garvin Hicking updated the commit message in patch set 2 V -1 04/21/25, 15:27

  5. core-ci voted on patch set 2 V -1 04/21/25, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77993

  6. Andreas Kienast uploaded patch set 3 V -1 04/22/25, 06:03

  7. core-ci voted on patch set 3 V +1 04/22/25, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78013

  8. Andreas Kienast commented on patch set 3 CR -2 04/22/25, 08:21

    This fixes symptoms, but not the cause as reported in the issue. Additional feedback has been requested from the author: https://forge.typo3.org/issues/105618#note-7
  9. Benni Mack marked it work in progress 04/22/25, 12:52

  10. Georg Ringer uploaded patch set 4 V +1 08/27/26, 16:44

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  11. Georg Ringer commented on patch set 4 08/27/26, 16:44

    This change is ready for review.
  12. core-ci voted on patch set 4 V +1 08/27/26, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107283

  13. Andreas Kienast voted on patch set 4 CR 0 08/28/26, 06:50

  14. Georg Ringer rebased onto patch set 5 V +1 10/02/26, 15:36

  15. core-ci voted on patch set 5 V +1 10/02/26, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109964

  16. Georg Ringer commented on patch set 5 11/03/26, 19:20

    Reply

    Done
  17. Benni Mack uploaded patch set 6 V +1 11/11/26, 09:42

  18. core-ci voted on patch set 6 V +1 11/11/26, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114031

  19. Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/15/26, 16:59