Review main Merged

89178[BUGFIX] Fix handling of legacy widgetRefresh event

Benjamin Franzke CR +2 V +2 Easy +6 −6 updated 04/23/25, 05:07

Commit message

Due to a bug in litnano camelCase event names where normalized to
lowercase, resulting in invalid events to be attached. Update to
litnano v1.0.1 which fixes this issue and ensures that declarative
event listeners are not mangled.

Commands executed:
  npm install --save-dev litnano@^1.0.1
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Benjamin Franzke uploaded patch set 1 04/21/25, 15:28

  2. core-ci voted on patch set 1 V +1 04/21/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77994

  3. Alexander Grein voted on patch set 1 CR +1 04/21/25, 16:39

  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 04/21/25, 20:27

  5. Garvin Hicking voted on patch set 2 CR +1 04/21/25, 20:27

  6. core-ci voted on patch set 2 V +1 04/21/25, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77995

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 04/22/25, 05:35

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 04/22/25, 14:40

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 04/22/25, 15:37

  10. Benni Mack voted on patch set 2 CR +1 04/22/25, 19:48

  11. Benjamin Franzke merged patch set 3 04/23/25, 05:07