89202[BUGFIX] Check state in web components extending `HTMLElement`
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
-
Verified V +2 Done
- Andreas Kienast +2
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/element/category-element.ts+6 −1
- Build/Sources/TypeScript/backend/form-engine/element/color-element.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/element/datetime-element.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/element/folder-element.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/element/json-element.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/element/password-element.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/element/text-element.ts+5 −0
- Build/Sources/TypeScript/backend/form-engine/field-wizard/value-slider.ts+5 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/category-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/color-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/datetime-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/folder-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/json-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/password-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/text-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-wizard/value-slider.js+1 −1
Review log 67
-
Andreas Kienast uploaded patch set 1 04/23/25, 10:53
-
core-ci voted on patch set 1 V +1 04/23/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78061
-
Oli Bartsch commented on patch set 1 04/24/25, 19:44
So should we also move event listener definition into the constructor, according to https://hawkticehurst.com/2023/11/you-are-probably-using-connectedcallback-wrong/ -
Andreas Kienast commented on patch set 1 04/25/25, 05:24
Reply
This sounds feasible. We must be extremely careful to do this only for event listeners bound to the web component directly (as stated in the article as well). Since this is an unmerged backport, I opt to start a new patch. -
Oli Bartsch commented on patch set 1 04/28/25, 15:24
Reply
Acknowledged -
Andreas Kienast voted on patch set 1 CR +2 V +2 05/21/25, 07:28
-
Andreas Kienast merged patch set 2 05/21/25, 07:28