Review main Merged

89204[BUGFIX] Retain navigation toggle state when switching modules

Andreas Kienast CR +2 V +2 Easy +4 −6 updated 04/24/25, 06:11

Commit message

The navigation component (aka "page tree") has a long standing issue
that the toggle state is not kept and would automatically expand again
if a backend module is opened.

When opening a backend module, the CSS class for expanding the
navigation is not forcefully set anymore, allowing to keep the toggle
state when switching modules. Instead, the navigation is forced to be
expanded when rendering the backend.

A related CSS bugfix binds the visibility of the navigation component to
the class `scaffold-content-navigation-available`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Andreas Kienast uploaded patch set 1 04/23/25, 12:56

  2. Andreas Kienast uploaded patch set 2 04/23/25, 12:57

  3. core-ci voted on patch set 1 V -1 04/23/25, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78063

  4. core-ci voted on patch set 2 V +1 04/23/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78064

  5. Andreas Kienast uploaded patch set 3 V +1 04/23/25, 13:31

  6. Benjamin Franzke voted on patch set 3 CR +1 V +1 04/23/25, 13:33

  7. core-ci voted on patch set 3 V +1 04/23/25, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78065

  8. Andreas Nedbal voted on patch set 3 CR +1 V +1 04/23/25, 14:46

  9. Andreas Kienast voted on patch set 3 CR +2 V +2 04/24/25, 06:03

  10. Andreas Kienast merged patch set 4 04/24/25, 06:11