Review main Merged

89205[BUGFIX] Set proper cache backend fallback in garbage collection task

Andreas Kienast CR +2 V +2 Easy +3 −2 updated 04/24/25, 06:32

Commit message

The scheduler task for Caching Framework garbage collection falsely sets
the caching backend to `null` as a fallback, which is wrong.

The documentation [1] states for "Database backend":

> This backend is the default backend if no backend is specifically set
> in the configuration.

This is also backed by the Bootstrap process [2] and the CacheManager [3].
The garbage collection task therefore now also uses
`Typo3DatabaseBackend` as default, if it is not explicitly configured.

[1] https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/CachingFramework/FrontendsBackends/Index.html#database-backend
[2] https://github.com/TYPO3/typo3/blob/v13.4.9/typo3/sysext/core/Classes/Core/Bootstrap.php#L350
[3] https://github.com/TYPO3/typo3/blob/v13.4.9/typo3/sysext/core/Classes/Cache/CacheManager.php#L62

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Andreas Kienast uploaded patch set 1 04/23/25, 13:56

  2. Andreas Kienast updated the commit message in patch set 2 04/23/25, 14:01

  3. core-ci voted on patch set 1 V +1 04/23/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78066

  4. core-ci voted on patch set 2 V +1 04/23/25, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78067

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 04/24/25, 05:40

  6. Benjamin Franzke voted on patch set 2 CR +1 04/24/25, 05:58

  7. Benjamin Franzke voted on patch set 2 V +1 04/24/25, 06:08

  8. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 04/24/25, 06:13

  9. Benjamin Franzke voted on patch set 3 CR +1 V +1 04/24/25, 06:14

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 04/24/25, 06:14

  11. core-ci voted on patch set 3 V +1 04/24/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78098

  12. Andreas Kienast voted on patch set 3 CR +2 V +2 04/24/25, 06:24

  13. Andreas Kienast merged patch set 4 04/24/25, 06:32