Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

89212[WIP][TASK] Use popup location to trigger downloading composed files

Oliver Hader CR 0 V 0 Easy +31 −6 updated 04/24/25, 08:53

Commit message

Current process behind the scenes:
* AJAX request troggers to create a composed zip file
* client loads the contents of the AJAX request into memory
* client creates blob reference for the retrieved file contents
* client creates "virtual" download for these blob files

CSP blocks anchor tags having a blob URI and the download attribute
(for whatever reason this is considered as navigation) in Firefox.

This change retries the download in case of a CSP violation. The
side-effect is a "flickering" due to staring the download in a
temporary new browser tab (target=_blank).

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/89212/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/89212/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 2

Review log 12

  1. Oliver Hader uploaded patch set 1 04/24/25, 08:46

  2. core-ci voted on patch set 1 V +1 04/24/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78103