Review 13.4 Merged

89220[BUGFIX] Adapt AssetRenderer paths for prefixing in FE rendering

Benni Mack CR +2 V +2 Normal +46 −15 updated 04/24/25, 11:27

Commit message

In FE context, `PageRenderer` renders said « relative » paths (full path
without the leading « / ») for CSS and JS files, so the
`TyposcriptFrontendController` can then add an absolute prefix if set via
`config.absRefPrefix` or `config.forceAbsoluteUrls`.

However this was not the case for paths rendered by `AssetRenderer`
which are absolute (full path with a leading « / »).
The leading slash prevents `TyposcriptFrontendController` setting the absolute
prefix because string substitution doesn’t match.

Inspired by how `PageRenderer` doesn't resolve absolute paths for FE to
avoid conflict with `config.absRefPrefix` or `config.forceAbsoluteUrls`,
AssetRenderer now behaves the same way.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 04/24/25, 11:17

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/24/25, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78117

  3. Benni Mack voted on patch set 1 CR +2 V +2 04/24/25, 11:25

  4. Benni Mack merged patch set 2 04/24/25, 11:27