Review main Merged

89226[BUGFIX] Always sort items "naturally" in filelist

Andreas Kienast CR +2 V +2 Normal +27 −64 updated 04/25/25, 08:44

Commit message

The collator option `\Collator::NUMERIC_COLLATION` is used to sort its
items in a natural manner as understood by human beings, which is now
always enabled.  Previously, the flag was only used when sorting by file
size.

Additionally, when reversing the result is requested, the calculation is
adjusted to handle this directly in `uksort()`, making the call of
`array_reverse()` obsolete.

Due to the removal of `array_reverse()`, array keys are not reset
anymore, therefore the tests have to use `assertEqualsCanonicalizing()`
as we only care about the correct order of the values. To have _this_
functional, we may not use mocked `ResourceInterface` instances due to
recursion limits.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Andreas Kienast uploaded patch set 1 04/24/25, 13:10

  2. core-ci voted on patch set 1 V -1 04/24/25, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78126

  3. Andreas Kienast uploaded patch set 2 V -1 04/24/25, 13:52

  4. Andreas Kienast uploaded patch set 3 04/24/25, 13:54

  5. core-ci voted on patch set 2 V +1 04/24/25, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78129

  6. core-ci voted on patch set 3 V +1 04/24/25, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78130

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 04/24/25, 14:06

  8. Oliver Klee voted on patch set 3 V +1 04/24/25, 14:13

  9. Benni Mack voted on patch set 3 CR +1 V +1 04/25/25, 06:41

  10. Andreas Kienast voted on patch set 3 CR +2 V +2 04/25/25, 06:54

  11. Andreas Kienast merged patch set 4 04/25/25, 08:44