Review main Merged

89238[TASK] Enforce trailing semicolon in TypeScript files

Andreas Kienast CR +2 V +2 Hard +276 −275 updated 04/25/25, 09:58

Commit message

The eslint rule `@stylistic/semi` is added to enforce semicolons at the
end of statements.

Executed command:

    ./Build/node_modules/.bin/eslint \
        -c ./Build/eslint.config.mjs \
        --fix ./Build/Sources/TypeScript/**/*.ts

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 95

Show 75 more files

Review log 1012

  1. Andreas Kienast uploaded patch set 1 04/25/25, 05:54

  2. core-ci voted on patch set 1 V +1 04/25/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78167

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 04/25/25, 06:11

  4. Simon Schaufelberger commented on patch set 1 04/25/25, 07:50

    how did you fix all these files? maybe add the command to the commit message Luke we often do with composer Updates or other commands executed
  5. Andreas Kienast updated the commit message in patch set 2 CR +1 V +1 04/25/25, 08:47

  6. Andreas Kienast commented on patch set 2 04/25/25, 08:47

    Reply

    Done
  7. Benni Mack voted on patch set 2 CR +1 V +1 04/25/25, 08:48

  8. Benjamin Franzke voted on patch set 2 CR +1 V +1 04/25/25, 08:50

  9. core-ci voted on patch set 2 V +1 04/25/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78171

  10. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/25/25, 08:59

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 04/25/25, 09:43

  12. Andreas Kienast merged patch set 3 04/25/25, 09:58