Review main Abandoned

89242[BUGFIX] Allow cType name as plugin name in f:link.action

Lina Wolf CR 0 V 0 Easy +6 −0 updated 05/28/25, 13:46

Commit message

The cType name is displayed in the backend
wherever a plugin is being used, they are also
used in tsconfig etc. Therefore the plugin
name and the ctype name are easy to mix up
and they are basicly different writings of the same concept.

Currently if an integrator accidently uses the ctype name like this:

<f:link.action action="choseTips" pluginName="myextension_tips" pageUid="...">
     Tipps hinzufügen
</f:link.action>

The generated links contain the extension name twice:

?tx_myextension_myextension_tips[action]

This leads to non working links that throw no exception, look right on first glance and can only be noticed when someone clicks them.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 810

  1. Lina Wolf uploaded patch set 1 04/26/25, 06:50

  2. core-ci voted on patch set 1 V -1 04/26/25, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78204

  3. Lina Wolf uploaded patch set 2 V -1 04/26/25, 06:58

  4. core-ci voted on patch set 2 V +1 04/26/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78205

  5. Stefan Bürk commented on patch set 2 04/27/25, 14:08

    I tend not to make this. At first because this is not a bug, it's simply user / integrator issue. When a plugin name is expected, pasing the combined ctype identifier is simply wrong and the integrator must correct this. Thinking further, shoud we also "set" the extension name out of the cytpe, but what if that is already set etc. This is a start of a forth and back normalization hiding away a simple configuration / parameter passing and allowing integrators to get sloppy on this.
  6. Stefan Bürk commented on patch set 2 04/27/25, 14:35

    Reply

    At best, manual provided pluginName should be verified if * pluginName is valid and exists * pluginName is valid for provided action eventually along with https://review.typo3.org/c/Packages/TYPO3.CMS/+/77294 and throwing a concrete exception that the plugin daoes not exists/is invalid for the extension/action etc. We should abstain from doing more and more user error correction and keeping "invalid" templates laying around. To make it clear, that silently "taking" the "invalid" value needs to be addressed, but in my eyes not by trying to "auto" correct it with some assumptions and in a incomplete manner. Beside that, this should also be done in a more generic place like the UriBuilder istead of the ViewHelplers. I'd say, that the `f:link.action` viewhelper has the same issue, and also other link/uri generating viewhelpers eventually.
  7. Oli Bartsch commented on patch set 2 V -1 04/29/25, 07:56

    Reply Unresolved

    As Stefan said, we should not implement such auto magic.
  8. Oli Bartsch commented on patch set 2 05/12/25, 15:28

    Unresolved

    Hi @112@linawolf.de, how to proceed here? Should we close this for now?
  9. Lina Wolf commented on patch set 2 05/28/25, 13:45

    Yes, seems like the majority disagrees with this solution
  10. Lina Wolf abandoned the change 05/28/25, 13:46

    Majority disagrees with this solution