Review main Merged

89245[TASK] Update mime-type collection & incorporate RFC 9512 (YAML)

Oliver Hader CR +2 V +2 Easy +40 −9 updated 04/29/25, 06:48

Commit message

Executed commands:
> cd Build && nvm use && npm update mime-db
> Scripts/generateMimeTypes.php

Besides that, https://datatracker.ietf.org/doc/html/rfc9512 has
been incorporated to support mime-types for YAML (which have not
been updated in the mentionend `mime-db` package, yet). Thus,
`application/yaml` is defined as fall-back.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1721

  1. Oliver Hader uploaded patch set 1 04/27/25, 14:50

  2. core-ci voted on patch set 1 V +1 04/27/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78233

  3. Benjamin Franzke commented on patch set 1 04/28/25, 07:10

    generateMimeTypes.php:37

    Do you have a concrete example at hand where `text/plain` is combined with structured syntax suffixes like `+yaml`? text/plain is less specific that `+yaml` and therefore does not provide any gains over `application/yaml`. I don't even find mentioning of that in https://datatracker.ietf.org/doc/html/rfc6839 – aren't structured syntax suffixes intended for low level mime-types that are augmented to be encoded in a specific format – like `application/epub+zip`? Maybe we should only add `application/yaml`?
  4. Oliver Hader uploaded patch set 2 V +1 04/28/25, 15:08

  5. Oliver Hader commented on patch set 2 04/28/25, 15:10

    generateMimeTypes.php:37 Reply

    Your remark is correct. I was trying to use a fall-back for systems still using `text/plain` for YAML files. However, unless with `image/svg+xml`, `+yaml` is only allowed for `application/*` media-types. I've removed `text/plain+yaml` from the change.
  6. Garvin Hicking commented on patch set 2 04/28/25, 15:16

    question: Is mhtml something we need to pay attention to, whether it enabley HTML/XSS...? Uploading these files might then be possible, and maybe loaded by browsers?
  7. core-ci voted on patch set 2 V +1 04/28/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78284

  8. Oliver Hader commented on patch set 2 04/28/25, 16:08

    Reply

    Discussed directly via Slack
  9. Benni Mack voted on patch set 2 CR +1 V +1 04/28/25, 19:29

  10. Garvin Hicking commented on patch set 2 CR +1 V +1 04/28/25, 19:53

    (What I gsthered, mhtml files are not natively interpreted by browders (anymore))
  11. Oliver Hader commented on patch set 2 CR -1 04/28/25, 20:30

    Argh, I forgot to regenerate the collection file...
  12. Oliver Hader rebased onto patch set 3 CR +1 V +1 04/28/25, 20:32

  13. Oliver Hader uploaded patch set 4 04/28/25, 20:33

  14. Benni Mack voted on patch set 4 CR +1 V +1 04/28/25, 20:40

  15. core-ci voted on patch set 3 V +1 04/28/25, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78300

  16. core-ci voted on patch set 4 V +1 04/28/25, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78301

  17. Garvin Hicking voted on patch set 4 CR +1 V +1 04/28/25, 20:57

  18. Benjamin Franzke voted on patch set 4 CR +1 V +1 04/29/25, 06:16

  19. Benjamin Franzke commented on patch set 4 04/29/25, 06:17

    generateMimeTypes.php:37 Reply

    alright, thx for clarification!
  20. Oliver Hader voted on patch set 4 CR +2 V +2 04/29/25, 06:48

  21. Oliver Hader merged patch set 5 04/29/25, 06:48