Review 13.4 Merged

89253[TASK] Update phpstan to 2.1.14

Anja Leichsenring CR +2 V +2 Easy +25 −25 updated 05/03/25, 06:25

Commit message

EvaluateDisplayConditions is adapted to avoid duplicated checks in
operator conditions which always evaluate to true.

Used commands:

> composer req --dev phpstan/phpstan:^2.1.14
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 610

  1. Anja Leichsenring uploaded patch set 1 04/28/25, 05:34

  2. core-ci voted on patch set 1 V +1 04/28/25, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78260

  3. Anja Leichsenring uploaded patch set 2 V +1 04/28/25, 13:20

  4. core-ci voted on patch set 2 V +1 04/28/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78277

  5. Benjamin Franzke uploaded patch set 3 V +1 05/03/25, 04:28

  6. core-ci voted on patch set 3 V -1 05/03/25, 04:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78457

  7. Benjamin Franzke uploaded patch set 4 V -1 05/03/25, 04:51

  8. core-ci voted on patch set 4 V +1 05/03/25, 04:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78462

  9. Benni Mack voted on patch set 4 CR +2 V +2 05/03/25, 06:25

  10. Benni Mack merged patch set 5 05/03/25, 06:25