Review 12.4 Merged

89256[BUGFIX] Load `draggable-resizable-element` in top-level scope

Andreas Kienast CR +2 V +2 Normal +93 −94 updated 04/28/25, 07:42

Commit message

The image cropping functionality allows to define so-named "focus areas"
to hint editors to respect a certain area while cropping pictures.

This functionality broke with #100948 in Firefox, as the web component
`@typo3/backend/element/draggable-resizable-element` is loaded within
the content frame context, but used in a modal window, which resides
in the outer backend scaffold context.

Explicitly loading the web component in top level is not enough, as
exports of said component are already loaded and used in
`image-manipulation`.

To solve this, several changes are done:

* the class `Offset` has been extracted into a new file and is now
  independently loaded in both affected modules, which avoids premature
  loading of `draggable-resizable-element` and therefore fixes the
  scoping in Firefox
* the consumers of `initFocusArea()` have been made async as well

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 34

  1. Andreas Kienast uploaded patch set 1 04/28/25, 07:21

  2. core-ci voted on patch set 1 V +1 04/28/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78268

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 04/28/25, 07:42

  4. Andreas Kienast merged patch set 2 04/28/25, 07:42