Review main Merged

89258[BUGFIX] Streamline DataHandler delete handling

Christian Kuhn CR +2 V +2 Hard +384 −486 updated 05/16/25, 13:36

Commit message

This is a bigger change to disentangle the delete handling
within DataHandler. The goal is to establish a more straight
call chain, to establish a cleaner entry method, to avoid
other parts of DataHandler misusing this code branch, to
improve performance by having the main BU::getRecord()
calls at fewer places and to have more centralized permission
checks.

We're also marking various quirky details with todo comments
to look at them with additional detail patches.

* Properly set record localization workspace overlays to
  deleted when deleting a workspace modified default
  language record.
* Add a missing access check when deleting modified workspace
  records.
* Method doesBranchExist() is renamed to getSubPagesOfPage(), only
  calculates sub page default language records and no longer checks
  permission details.
* Various methods get the full record hand over instead of
  fetching them over and over again.
* Method deleteAction() is now the public low level entry method
  to delete instead of deleteEl().
* Avoid property deletedRecords and its handling. It is useless
  with the better streamline logic.

The v13 backport will keep deleteEl() public.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 75145

Show 60120 earlier messages
  1. Christian Kuhn uploaded patch set 1 04/28/25, 11:08

  2. core-ci voted on patch set 1 V -1 04/28/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78270

  3. Christian Kuhn uploaded patch set 2 V -1 04/28/25, 11:32

  4. core-ci voted on patch set 2 V -1 04/28/25, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78272

  5. Christian Kuhn uploaded patch set 3 V -1 04/28/25, 13:48

  6. core-ci voted on patch set 3 V -1 04/28/25, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78280

  7. Christian Kuhn uploaded patch set 4 V -1 04/28/25, 13:59

  8. core-ci voted on patch set 4 V -1 04/28/25, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78281

  9. Christian Kuhn uploaded patch set 5 V -1 04/28/25, 16:09

  10. core-ci voted on patch set 5 V +1 04/28/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78291

  11. Christian Kuhn uploaded patch set 6 V +1 04/28/25, 16:46

  12. core-ci voted on patch set 6 V +1 04/28/25, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78293

  13. Christian Kuhn uploaded patch set 7 V +1 04/28/25, 17:55

  14. core-ci voted on patch set 7 V +1 04/28/25, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78294

  15. Christian Kuhn uploaded patch set 8 V +1 04/29/25, 12:41

  16. core-ci voted on patch set 8 V +1 04/29/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78349

  17. Christian Kuhn uploaded patch set 9 V +1 04/29/25, 12:59

  18. core-ci voted on patch set 9 V +1 04/29/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78350

  19. Christian Kuhn uploaded patch set 10 V +1 04/29/25, 14:18

  20. core-ci voted on patch set 10 V -1 04/29/25, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78356

  21. Christian Kuhn uploaded patch set 11 V -1 04/29/25, 14:41

  22. core-ci voted on patch set 11 V +1 04/29/25, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78358

  23. Christian Kuhn uploaded patch set 12 V +1 04/29/25, 18:49

  24. core-ci voted on patch set 12 V -1 04/29/25, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78365

  25. Christian Kuhn uploaded patch set 13 V -1 04/30/25, 08:33

  26. core-ci voted on patch set 13 V -1 04/30/25, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78384

  27. Christian Kuhn uploaded patch set 14 V -1 04/30/25, 10:01

  28. core-ci voted on patch set 14 V +1 04/30/25, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78388

  29. Christian Kuhn uploaded patch set 15 V +1 04/30/25, 10:54

  30. core-ci voted on patch set 15 V +1 04/30/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78389

  31. Christian Kuhn uploaded patch set 16 V +1 04/30/25, 11:29

  32. core-ci voted on patch set 16 V -1 04/30/25, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78390

  33. Christian Kuhn uploaded patch set 17 V -1 04/30/25, 11:56

  34. core-ci voted on patch set 17 V +1 04/30/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78391

  35. Christian Kuhn uploaded patch set 18 V +1 04/30/25, 12:02

  36. core-ci voted on patch set 18 V +1 04/30/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78392

  37. Christian Kuhn uploaded patch set 19 V +1 04/30/25, 12:11

  38. core-ci voted on patch set 19 V +1 04/30/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78393

  39. Christian Kuhn uploaded patch set 20 V +1 04/30/25, 12:37

  40. core-ci voted on patch set 20 V +1 04/30/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78394

  41. Christian Kuhn uploaded patch set 21 V +1 04/30/25, 13:13

  42. core-ci voted on patch set 21 V +1 04/30/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78396

  43. Christian Kuhn uploaded patch set 22 V +1 04/30/25, 14:33

  44. core-ci voted on patch set 22 V -1 04/30/25, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78397

  45. core-ci commented on patch set 22 04/30/25, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78397

  46. Christian Kuhn uploaded patch set 23 V -1 04/30/25, 15:04

  47. core-ci voted on patch set 23 V +1 04/30/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78398

  48. Christian Kuhn uploaded patch set 24 V +1 04/30/25, 16:24

  49. Christian Kuhn uploaded patch set 25 04/30/25, 16:32

  50. core-ci voted on patch set 24 V -1 04/30/25, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78402

  51. core-ci voted on patch set 25 V +1 04/30/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78403

  52. Christian Kuhn uploaded patch set 26 V +1 04/30/25, 16:43

  53. core-ci voted on patch set 26 V +1 04/30/25, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78404

  54. Christian Kuhn uploaded patch set 27 V +1 04/30/25, 17:22

  55. core-ci voted on patch set 27 V +1 04/30/25, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78405

  56. Christian Kuhn rebased onto patch set 28 V +1 05/05/25, 10:18

  57. core-ci voted on patch set 28 V +1 05/05/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78516

  58. Christian Kuhn uploaded patch set 29 V +1 05/05/25, 12:23

  59. core-ci voted on patch set 29 V +1 05/05/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78521

  60. Christian Kuhn uploaded patch set 30 V +1 05/05/25, 12:50

  61. core-ci voted on patch set 30 V +1 05/05/25, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78527

  62. Christian Kuhn uploaded patch set 31 V +1 05/05/25, 13:53

  63. core-ci voted on patch set 31 V +1 05/05/25, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78535

  64. Christian Kuhn uploaded patch set 32 V +1 05/05/25, 14:54

  65. core-ci voted on patch set 32 V +1 05/05/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78548

  66. Christian Kuhn uploaded patch set 33 V +1 05/05/25, 15:30

  67. core-ci voted on patch set 33 V +1 05/05/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78551

  68. Christian Kuhn rebased onto patch set 34 V +1 05/06/25, 08:31

  69. core-ci voted on patch set 34 V +1 05/06/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78587

  70. Christian Kuhn uploaded patch set 35 V +1 05/06/25, 10:42

  71. core-ci voted on patch set 35 V +1 05/06/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78595

  72. Christian Kuhn uploaded patch set 36 V +1 05/06/25, 10:54

  73. core-ci voted on patch set 36 V +1 05/06/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78596

  74. Christian Kuhn uploaded patch set 37 V +1 05/06/25, 12:18

  75. core-ci voted on patch set 37 V +1 05/06/25, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78597

  76. Christian Kuhn uploaded patch set 38 V +1 05/06/25, 12:44

  77. core-ci voted on patch set 38 V -1 05/06/25, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78598

  78. Christian Kuhn uploaded patch set 39 V -1 05/06/25, 12:55

  79. core-ci voted on patch set 39 V +1 05/06/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78599

  80. Christian Kuhn uploaded patch set 40 V +1 05/06/25, 15:21

  81. core-ci voted on patch set 40 V +1 05/06/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78602

  82. Christian Kuhn uploaded patch set 41 V +1 05/06/25, 15:29

  83. Christian Kuhn uploaded patch set 42 05/06/25, 15:31

  84. core-ci voted on patch set 41 V -1 05/06/25, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78603

  85. core-ci voted on patch set 42 V -1 05/06/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78604

  86. Christian Kuhn uploaded patch set 43 V -1 05/06/25, 15:39

  87. core-ci voted on patch set 43 V +1 05/06/25, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78605

  88. Christian Kuhn uploaded patch set 44 V +1 05/06/25, 15:46

  89. core-ci voted on patch set 44 V +1 05/06/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78606

  90. Christian Kuhn uploaded patch set 45 V +1 05/06/25, 16:13

  91. core-ci voted on patch set 45 V +1 05/06/25, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78607

  92. Christian Kuhn uploaded patch set 46 V +1 05/06/25, 18:05

  93. Christian Kuhn uploaded patch set 47 05/06/25, 18:06

  94. core-ci voted on patch set 47 V +1 05/06/25, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78609

  95. core-ci voted on patch set 46 V +1 05/06/25, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78608

  96. Christian Kuhn uploaded patch set 48 V +1 05/07/25, 09:46

  97. core-ci voted on patch set 48 V +1 05/07/25, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78629

  98. Christian Kuhn uploaded patch set 49 V +1 05/15/25, 12:35

  99. core-ci voted on patch set 49 V +1 05/15/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78968

  100. Christian Kuhn uploaded patch set 50 V +1 05/15/25, 13:38

  101. core-ci voted on patch set 50 V +1 05/15/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78972

  102. Christian Kuhn uploaded patch set 51 V +1 05/15/25, 13:48

  103. core-ci voted on patch set 51 V +1 05/15/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78973

  104. Christian Kuhn uploaded patch set 52 V +1 05/15/25, 14:15

  105. core-ci voted on patch set 52 V +1 05/15/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78975

  106. Christian Kuhn uploaded patch set 53 V +1 05/15/25, 14:34

  107. core-ci voted on patch set 53 V +1 05/15/25, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78976

  108. Christian Kuhn uploaded patch set 54 V +1 05/15/25, 14:46

  109. Christian Kuhn uploaded patch set 55 05/15/25, 14:49

  110. core-ci voted on patch set 54 V +1 05/15/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78978

  111. Christian Kuhn uploaded patch set 56 05/15/25, 14:56

  112. core-ci voted on patch set 55 V +1 05/15/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78979

  113. core-ci voted on patch set 56 V +1 05/15/25, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78980

  114. Christian Kuhn uploaded patch set 57 V +1 05/15/25, 15:09

  115. Christian Kuhn uploaded patch set 58 05/15/25, 15:13

  116. Christian Kuhn updated the commit message in patch set 59 05/15/25, 15:17

  117. core-ci voted on patch set 57 V -1 05/15/25, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78981

  118. Christian Kuhn updated the commit message in patch set 60 05/15/25, 15:23

  119. core-ci voted on patch set 58 V -1 05/15/25, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78982

  120. core-ci voted on patch set 59 V -1 05/15/25, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78983

  1. core-ci voted on patch set 60 V -1 05/15/25, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78984

  2. Christian Kuhn uploaded patch set 61 V -1 05/15/25, 15:53

  3. Christian Kuhn uploaded patch set 62 05/15/25, 15:56

  4. core-ci voted on patch set 61 V +1 05/15/25, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78985

  5. core-ci voted on patch set 62 V +1 05/15/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78986

  6. Christian Kuhn uploaded patch set 63 V +1 05/15/25, 16:13

  7. Christian Kuhn uploaded patch set 64 05/15/25, 16:23

  8. Christian Kuhn uploaded patch set 65 05/15/25, 16:24

  9. core-ci voted on patch set 63 V -1 05/15/25, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78988

  10. Christian Kuhn updated the commit message in patch set 66 05/15/25, 16:27

  11. core-ci voted on patch set 64 V -1 05/15/25, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78989

  12. core-ci voted on patch set 65 V +1 05/15/25, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78990

  13. core-ci voted on patch set 66 V +1 05/15/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78991

  14. Benni Mack voted on patch set 66 CR +1 V +1 05/16/25, 09:09

  15. Christian Kuhn rebased onto patch set 67 CR +1 V +1 05/16/25, 11:01

  16. core-ci voted on patch set 67 V +1 05/16/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79044

  17. Christian Kuhn uploaded patch set 68 V +1 05/16/25, 11:15

  18. Christian Kuhn commented on patch set 68 05/16/25, 11:16

    Note we will push, but delay the v13 backport for a couple of days.
  19. core-ci voted on patch set 68 V +1 05/16/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79047

  20. Christian Kuhn uploaded patch set 69 05/16/25, 11:43

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  21. core-ci voted on patch set 69 V +1 05/16/25, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79055

  22. Stefan Bürk voted on patch set 69 CR +1 V +1 05/16/25, 11:58

  23. Benni Mack voted on patch set 69 CR +1 V +1 05/16/25, 12:49

  24. Christian Kuhn voted on patch set 69 CR +2 V +2 05/16/25, 13:36

  25. Christian Kuhn merged patch set 70 05/16/25, 13:36