Review 13.4 Merged

89279[BUGFIX] Convert container-dependent Site tests to functional tests

Andreas Kienast CR +2 V +2 Normal +87 −101 updated 04/29/25, 11:53

Commit message

The test class `TYPO3\CMS\Core\Tests\Unit\Site\Entity\SiteTest` has some
unit tests that taint the dependency injection container which may spill
into other tests that depend on a clean state. This occured in the past
when running unit tests in random order:

```
1) TYPO3\CMS\Frontend\Tests\Unit\Typolink\EmailLinkBuilderTest::invalidEmailGetsHscedProperly
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<a href="#" data-mailto-token="pdlowr-qr&#039;pdloCdfph1frp" data-mailto-vector="3">no&#039;mail(at)acme.com</a>'
+'<a href="#" data-mailto-token="" data-mailto-vector="3">no&#039;mail(at)acme.com</a>'
/builds/typo3/CI/cms/typo3/sysext/frontend/Tests/Unit/Typolink/EmailLinkBuilderTest.php:108
```

The affected tests are now converted into a functional test, where
container modifications are not required.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Andreas Kienast uploaded patch set 1 04/29/25, 11:08

  2. core-ci voted on patch set 1 V -1 04/29/25, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78345

  3. Andreas Kienast uploaded patch set 2 V -1 04/29/25, 11:39

  4. core-ci voted on patch set 2 V +1 04/29/25, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78347

  5. Andreas Kienast voted on patch set 2 CR +2 V +2 04/29/25, 11:53

  6. Andreas Kienast merged patch set 3 04/29/25, 11:53