89282[BUGFIX] Add label to target selection in link browser
Commit message
Review
-
Code review CR -1
- Jörg Bösche +1
- Benjamin Kott -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/forms/_input-group.scss+24 −25
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php+6 −5
- typo3/sysext/backend/Resources/Private/Language/locallang_browse_links.xlf2+7 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −2
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+8 −8
Review log 1622
-
Christian Rath-Ulrich uploaded patch set 1 04/29/25, 16:50
-
core-ci voted on patch set 1 V +1 04/29/25, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78363
-
Benni Mack commented on patch set 1 04/30/25, 15:39
any reason to have this in main-only? -
Christian Rath-Ulrich commented on patch set 1 04/30/25, 17:30
Reply
No, but I could not choose more than one version. -
Benni Mack updated the commit message in patch set 2
V +104/30/25, 20:45 -
Benni Mack updated the commit message in patch set 3 04/30/25, 20:49
-
core-ci voted on patch set 2 V +1 04/30/25, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78411
-
core-ci voted on patch set 3 V +1 04/30/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78412
-
Michael Telgkamp commented on patch set 3 CR -1 05/02/25, 13:20
locallang_browse_links.xlf:66Here the key of `target` is changed to `target-legend` but no legend is added in the form fieldsets. It could be considered to use a legend there, but as both translations (`target` and `target-type`) include the value of the `target-legend`, a `legend` is not required. If this is the case, the translation for `target-legend` should be removed. -
Christian Rath-Ulrich uploaded patch set 4
CR -1V +105/02/25, 19:50 -
Christian Rath-Ulrich commented on patch set 4 05/02/25, 19:55
locallang_browse_links.xlf:66ReplyDone -
core-ci voted on patch set 4 V +1 05/02/25, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78447
-
Oliver Klee updated the commit message in patch set 5
V +105/04/25, 09:18 -
core-ci voted on patch set 5 V +1 05/04/25, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78486
-
Michael Telgkamp voted on patch set 5 CR +1 V +1 05/05/25, 06:35
-
Andreas Kienast commented on patch set 5 V -1 05/05/25, 06:52
The UI looks broken now, the fields miss a border radius. -
Christian Rath-Ulrich uploaded patch set 6
CR +1V +105/11/25, 17:26 -
core-ci voted on patch set 6 V +1 05/11/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78779
-
Jörg Bösche voted on patch set 6 CR +1 08/18/25, 11:29
-
Benjamin Kott commented on patch set 6 CR -1 09/09/25, 12:02
this patch is not solving the issue in general in a good way. From an A11Y perspective we have a classic Combobox here and it should also use a pattern matching this. See: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/combobox_role or https://w3c.github.io/aria/#combobox this needs a bigger refactoring in this area and the introduction of a new component to handle this. -
Benjamin Kott abandoned the change 10/02/25, 13:37
dropped in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/90694