Review main Abandoned

89282[BUGFIX] Add label to target selection in link browser

Christian Rath-Ulrich CR -1 V 0 Normal +48 −41 updated 10/02/25, 13:37

Commit message

Review

  • Code review CR -1
    • Jörg Bösche +1
    • Benjamin Kott -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 5

Review log 1622

  1. Christian Rath-Ulrich uploaded patch set 1 04/29/25, 16:50

  2. core-ci voted on patch set 1 V +1 04/29/25, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78363

  3. Benni Mack commented on patch set 1 04/30/25, 15:39

    any reason to have this in main-only?
  4. Christian Rath-Ulrich commented on patch set 1 04/30/25, 17:30

    Reply

    No, but I could not choose more than one version.
  5. Benni Mack updated the commit message in patch set 2 V +1 04/30/25, 20:45

  6. Benni Mack updated the commit message in patch set 3 04/30/25, 20:49

  7. core-ci voted on patch set 2 V +1 04/30/25, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78411

  8. core-ci voted on patch set 3 V +1 04/30/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78412

  9. Michael Telgkamp commented on patch set 3 CR -1 05/02/25, 13:20

    locallang_browse_links.xlf:66

    Here the key of `target` is changed to `target-legend` but no legend is added in the form fieldsets. It could be considered to use a legend there, but as both translations (`target` and `target-type`) include the value of the `target-legend`, a `legend` is not required. If this is the case, the translation for `target-legend` should be removed.
  10. Christian Rath-Ulrich uploaded patch set 4 CR -1 V +1 05/02/25, 19:50

  11. Christian Rath-Ulrich commented on patch set 4 05/02/25, 19:55

    locallang_browse_links.xlf:66 Reply

    Done
  12. core-ci voted on patch set 4 V +1 05/02/25, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78447

  13. Oliver Klee updated the commit message in patch set 5 V +1 05/04/25, 09:18

  14. core-ci voted on patch set 5 V +1 05/04/25, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78486

  15. Michael Telgkamp voted on patch set 5 CR +1 V +1 05/05/25, 06:35

  16. Andreas Kienast commented on patch set 5 V -1 05/05/25, 06:52

    The UI looks broken now, the fields miss a border radius.
  17. Christian Rath-Ulrich uploaded patch set 6 CR +1 V +1 05/11/25, 17:26

  18. core-ci voted on patch set 6 V +1 05/11/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78779

  19. Christian Rath-Ulrich commented on patch set 6 05/13/25, 08:29

    Reply

    Done
    fixed the Border radius
  20. Jörg Bösche voted on patch set 6 CR +1 08/18/25, 11:29

  21. Benjamin Kott commented on patch set 6 CR -1 09/09/25, 12:02

    this patch is not solving the issue in general in a good way. From an A11Y perspective we have a classic Combobox here and it should also use a pattern matching this. See: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/combobox_role or https://w3c.github.io/aria/#combobox this needs a bigger refactoring in this area and the introduction of a new component to handle this.
  22. Benjamin Kott abandoned the change 10/02/25, 13:37