Review main Merged

89283[BUGFIX] Avoid PHP errors with broken FE URL arguments

Christian Kuhn CR +2 V +2 Normal +26 −29 updated 05/08/25, 09:20

Commit message

When 'type', 'cHash' or '__RequestToken' URL arguments
are arrays, FE triggers 'Array to string conversion'
warning level PHP errors. TYPO3 never creates such links,
this is usually "external manipulation". Still, the FE
should not crash on this. The patch sanitizes these
cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1218

  1. Christian Kuhn uploaded patch set 1 04/30/25, 09:22

  2. core-ci voted on patch set 1 V -1 04/30/25, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78385

  3. Christian Kuhn uploaded patch set 2 V -1 04/30/25, 09:53

  4. Christian Kuhn uploaded patch set 3 04/30/25, 09:55

  5. core-ci voted on patch set 2 V -1 04/30/25, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78386

  6. core-ci voted on patch set 3 V +1 04/30/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78387

  7. Christian Kuhn uploaded patch set 4 V +1 05/07/25, 14:23

  8. core-ci voted on patch set 4 V +1 05/07/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78637

  9. Christian Kuhn uploaded patch set 5 V +1 05/07/25, 14:30

  10. core-ci voted on patch set 5 V +1 05/07/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78638

  11. Oliver Klee voted on patch set 5 CR +1 05/07/25, 15:28

  12. Georg Ringer updated the commit message in patch set 6 CR +1 V +1 05/07/25, 17:02

  13. Georg Ringer voted on patch set 6 CR +1 V +1 05/07/25, 17:02

  14. core-ci voted on patch set 6 V +1 05/07/25, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78639

  15. Benni Mack voted on patch set 6 CR +1 V +1 05/07/25, 21:57

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 05/08/25, 00:07

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 05/08/25, 09:20

  18. Christian Kuhn merged patch set 7 05/08/25, 09:20