Review main Merged

89296[TASK] Enable DI in scheduler task objects

Benni Mack CR +2 V +2 Normal +5 −51 updated 05/06/25, 06:03

Commit message

Due to previous work in the scheduler extension
custom scheduler tasks can now use Dependency
Injection starting with TYPO3 v14.0.

They still need to be configured as "public service"
due to the usage of GeneralUtility::makeInstance()
but this might change also rather sooner than later.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 69

  1. Benni Mack uploaded patch set 1 05/05/25, 08:09

  2. core-ci voted on patch set 1 V -1 05/05/25, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78513

  3. Benni Mack uploaded patch set 2 V -1 05/05/25, 20:11

  4. core-ci voted on patch set 2 V +1 05/05/25, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78554

  5. Benni Mack updated the commit message in patch set 3 V +1 05/05/25, 20:47

  6. core-ci voted on patch set 3 V +1 05/05/25, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78555

  7. Andreas Kienast voted on patch set 3 CR +1 V +1 05/06/25, 05:56

  8. Georg Ringer voted on patch set 3 CR +2 V +2 05/06/25, 06:03

  9. Georg Ringer merged patch set 4 05/06/25, 06:03