89301[TASK] Always use default language binding in page module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Sven Liebert +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Sven Liebert +1
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+1 −1
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+1 −41
- typo3/sysext/backend/Classes/View/Drawing/DrawingConfiguration.php+0 −14
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+5 −0
- typo3/sysext/backend/Classes/View/PageViewMode.php+0 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html2+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/drag-drop.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Important-106649-DefaultLanguageBindingInPageModule.rstnew+37 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+2 −2
Review log 2127
Show 12 earlier messages
-
Oli Bartsch uploaded patch set 1 05/05/25, 21:00
-
core-ci voted on patch set 1 V -1 05/05/25, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78556
-
Oli Bartsch uploaded patch set 2
V -105/05/25, 21:27 -
core-ci voted on patch set 1 V -1 05/05/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78556
-
core-ci voted on patch set 2 V -1 05/05/25, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78557
-
Oli Bartsch uploaded patch set 3
V -105/05/25, 21:51 -
core-ci voted on patch set 3 V +1 05/05/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78559
-
Sven Liebert voted on patch set 3 CR +1 V +1 05/05/25, 22:14
-
Benni Mack commented on patch set 3 CR -1 05/05/25, 22:19
something is not correct -
Benni Mack commented on patch set 3 05/05/25, 22:21
When having only default language active, there is now much more space which seems unneeded. @benjamin.kott@outlook.com please fix. -
Benjamin Kott commented on patch set 3 CR -1 05/05/25, 22:58
yes, i knew - just need to rebuild the page module for that css / markup -
Oli Bartsch uploaded patch set 4
CR +1V +105/05/25, 23:01 -
Oli Bartsch commented on patch set 4 05/05/25, 23:03
@benni@typo3.org @benjamin.kott@outlook.com Issue is fixed by not using def lang layout in case language comparison is used with only default language. -
core-ci voted on patch set 4 V +1 05/05/25, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78566
-
Oli Bartsch commented on patch set 4 CR -2 05/06/25, 09:21
@benjamin.kott@outlook.com @benni@typo3.org Let's improve def lang binding UI before we make this the default view. -
Oli Bartsch uploaded patch set 5
V +105/06/25, 09:28Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 5 V +1 05/06/25, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78591
-
Oli Bartsch commented on patch set 5 CR 0 05/06/25, 10:09
Reply
Thought about it again. Let's get this in and make bigger page module refactoring afterwards. -
Andreas Kienast commented on patch set 5 05/06/25, 10:25
LanguageColumns.html:75Should we use `context.multiLanguages` here as well? -
Andreas Kienast commented on patch set 5 05/06/25, 10:32
LanguageColumns.html:75ReplyNever mind, I misread the code... -
Andreas Kienast voted on patch set 5 CR +1 V +1 05/06/25, 10:43
-
Benni Mack voted on patch set 5 CR +1 05/06/25, 19:35
-
Benni Mack voted on patch set 5 V +1 05/07/25, 06:25
-
Georg Ringer voted on patch set 5 CR +1 V +1 05/07/25, 06:27
-
Oli Bartsch voted on patch set 5 CR +2 V +2 05/07/25, 08:34
-
Sven Liebert voted on patch set 5 CR +1 V +1 05/07/25, 08:50
-
Oli Bartsch merged patch set 6 05/07/25, 09:32