Review main Merged

89301[TASK] Always use default language binding in page module

Oli Bartsch CR +2 V +2 Normal +50 −63 updated 05/07/25, 09:32

Commit message

The default language binding in the page module
is now always enabled and the corresponding TSconfig
setting is no longer evaluated.

Using default language binding makes editing translations
easier, because editors can see what they’re translating
next to the default language. It additionally prevents
confusion when localizations are incomplete. Editors
directly see which content is not translated yet.

This improves UX in the backend for multilingual sites,
which was also a result of recent JTBD interviews.

Using language comparison mode with only the default
language, no splitting is applied to remove unecessary
margins.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Sven Liebert +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Sven Liebert +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2127

Show 12 earlier messages
  1. Oli Bartsch uploaded patch set 1 05/05/25, 21:00

  2. core-ci voted on patch set 1 V -1 05/05/25, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78556

  1. Oli Bartsch uploaded patch set 2 V -1 05/05/25, 21:27

  2. core-ci voted on patch set 1 V -1 05/05/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78556

  3. core-ci voted on patch set 2 V -1 05/05/25, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78557

  4. Oli Bartsch uploaded patch set 3 V -1 05/05/25, 21:51

  5. core-ci voted on patch set 3 V +1 05/05/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78559

  6. Sven Liebert voted on patch set 3 CR +1 V +1 05/05/25, 22:14

  7. Benni Mack commented on patch set 3 CR -1 05/05/25, 22:19

    something is not correct
  8. Benni Mack commented on patch set 3 05/05/25, 22:21

    When having only default language active, there is now much more space which seems unneeded. @benjamin.kott@outlook.com please fix.
  9. Benjamin Kott commented on patch set 3 CR -1 05/05/25, 22:58

    yes, i knew - just need to rebuild the page module for that css / markup
  10. Oli Bartsch uploaded patch set 4 CR +1 V +1 05/05/25, 23:01

  11. Oli Bartsch commented on patch set 4 05/05/25, 23:03

    @benni@typo3.org @benjamin.kott@outlook.com Issue is fixed by not using def lang layout in case language comparison is used with only default language.
  12. core-ci voted on patch set 4 V +1 05/05/25, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78566

  13. Oli Bartsch commented on patch set 4 CR -2 05/06/25, 09:21

    @benjamin.kott@outlook.com @benni@typo3.org Let's improve def lang binding UI before we make this the default view.
  14. Oli Bartsch uploaded patch set 5 V +1 05/06/25, 09:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. core-ci voted on patch set 5 V +1 05/06/25, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78591

  16. Oli Bartsch commented on patch set 5 CR 0 05/06/25, 10:09

    Reply

    Thought about it again. Let's get this in and make bigger page module refactoring afterwards.
  17. Andreas Kienast commented on patch set 5 05/06/25, 10:25

    LanguageColumns.html:75

    Should we use `context.multiLanguages` here as well?
  18. Andreas Kienast commented on patch set 5 05/06/25, 10:32

    LanguageColumns.html:75 Reply

    Never mind, I misread the code...
  19. Andreas Kienast voted on patch set 5 CR +1 V +1 05/06/25, 10:43

  20. Benni Mack voted on patch set 5 CR +1 05/06/25, 19:35

  21. Benni Mack voted on patch set 5 V +1 05/07/25, 06:25

  22. Georg Ringer voted on patch set 5 CR +1 V +1 05/07/25, 06:27

  23. Oli Bartsch voted on patch set 5 CR +2 V +2 05/07/25, 08:34

  24. Sven Liebert voted on patch set 5 CR +1 V +1 05/07/25, 08:50

  25. Oli Bartsch merged patch set 6 05/07/25, 09:32