Review main Merged

89306[TASK] Modified button toolbar in backend users module

Marno Schmigotzki CR +2 V +2 Easy +19 −3 updated 05/16/25, 09:35

Commit message

In order to create admin backend users more quickly
two buttons "Create editor" and "Create admin" are
now provided in the "Backend Users" module.

* Added new button "Create admin" to "Backend Users".
* Renamed button "Create new backend user" to "Create editor".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Marno Schmigotzki uploaded patch set 1 05/05/25, 22:48

  2. core-ci voted on patch set 1 V -1 05/05/25, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78565

  3. Oliver Hader commented on patch set 1 05/05/25, 22:57

    BackendUserController.php:195

    Comma (`,`) at the end is missing here according to coding-guide-lines
  4. Marno Schmigotzki uploaded patch set 2 V -1 05/06/25, 08:53

  5. Marno Schmigotzki commented on patch set 2 05/06/25, 08:54

    BackendUserController.php:195 Reply

    Done
  6. core-ci voted on patch set 2 V +1 05/06/25, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78588

  7. Stefan Bürk updated the commit message in patch set 3 V +1 05/06/25, 14:54

  8. Stefan Bürk updated the commit message in patch set 4 05/06/25, 14:54

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 05/06/25, 14:55

  10. core-ci voted on patch set 3 V +1 05/06/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78600

  11. core-ci voted on patch set 4 V +1 05/06/25, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78601

  12. Georg Ringer commented on patch set 4 V -1 05/06/25, 19:00

    I will ask the UX team in slack for feedback, as I see some other options as well: - use a dropdown link, just like on right side with sharing - provide icons for admin/regular editor within the button
  13. Benjamin Kott commented on patch set 4 CR +1 V +1 05/15/25, 06:10

    This patch was created and discussed during the surfcamp. We actively decided against split buttons here, to help users make quicker decisions. This is fine for now and can be improved further down the road.
  14. Stefan Bürk rebased onto patch set 5 CR +1 V +1 05/15/25, 06:11

  15. Benjamin Kott voted on patch set 5 CR +1 V +1 05/15/25, 06:12

  16. core-ci voted on patch set 5 V +1 05/15/25, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78939

  17. Christian Kuhn voted on patch set 5 CR +1 V +1 05/16/25, 09:34

  18. Benni Mack voted on patch set 5 CR +2 V +2 05/16/25, 09:35

  19. Benni Mack merged patch set 6 05/16/25, 09:35