Review main Merged

89310[BUGFIX] Keep overridden URL in NewContentElementController

Benni Mack CR +2 V +2 Easy +26 −18 updated 05/12/25, 14:11

Commit message

This change ensures that values, especially "url" from
`ModifyNewContentElementWizardItemsEvent`, are kept from
the wizard in order to allow Event Listeners to override
the URL.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Benni Mack uploaded patch set 1 05/06/25, 19:41

  2. core-ci voted on patch set 1 V +1 05/06/25, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78610

  3. Georg Ringer updated the commit message in patch set 2 V +1 05/06/25, 22:11

  4. Georg Ringer voted on patch set 2 CR +1 V +1 05/06/25, 22:11

  5. core-ci voted on patch set 2 V +1 05/06/25, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78612

  6. Oli Bartsch commented on patch set 2 05/08/25, 08:29

    NewContentElementController.php:144

    Why do we execute below functionality at all in case $wizardItem['url'] is set when we not use it in the end?
  7. Benni Mack uploaded patch set 3 CR +1 V +1 05/09/25, 14:49

  8. Benni Mack commented on patch set 3 05/09/25, 14:49

    NewContentElementController.php:144 Reply

    Done
  9. core-ci voted on patch set 3 V +1 05/09/25, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78732

  10. Oliver Klee updated the commit message in patch set 4 V +1 05/09/25, 15:12

  11. core-ci voted on patch set 4 V +1 05/09/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78735

  12. Georg Ringer voted on patch set 4 CR +1 V +1 05/10/25, 13:56

  13. Oli Bartsch voted on patch set 4 CR +2 V +2 05/12/25, 14:11

  14. Oli Bartsch merged patch set 5 05/12/25, 14:11